Last modified: 2010-05-15 15:33:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3642, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 1642 - img_auth.php bugfix


Summary:	img_auth.php bugfix

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	File management (Other open bugs)
Version:	1.4.x
Hardware:	Other All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-03-07 05:00 UTC by Ævar Arnfjörð Bjarmason
Modified:	2010-05-15 15:33 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
the patch against img_auth.php (617 bytes, patch) 2005-03-07 05:01 UTC, Ævar Arnfjörð Bjarmason	Details
Updated the patch (548 bytes, patch) 2005-03-07 06:02 UTC, Ævar Arnfjörð Bjarmason	Details
A testcase which shows that the "; causes problems (2.75 KB, text/plain) 2005-03-07 06:03 UTC, Ævar Arnfjörð Bjarmason	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Ævar Arnfjörð Bjarmason 2005-03-07 05:00:36 UTC

This patch fixes a small bug in img_auth.php and cleans up the code by avoiding
a needless variable which makes it harder to understand.

Comment 1 Ævar Arnfjörð Bjarmason 2005-03-07 05:01:18 UTC

Created attachment 336 [details]
the patch against img_auth.php

Comment 2 Brion Vibber 2005-03-07 05:38:00 UTC

The $endl bit is there because a file checked out on a Windows server will have CRLF line feeds instead of LF.

Comment 3 Ævar Arnfjörð Bjarmason 2005-03-07 06:02:25 UTC

Created attachment 337 [details]
Updated the patch

Despite my patch not accounting for CRLF line feeds the bug as a whole is not
INVALID, only half of it, the x-conference/x-cooltalk ice"; line still needs to
be changed to x-conference/x-cooltalk ice.

Comment 4 Ævar Arnfjörð Bjarmason 2005-03-07 06:03:37 UTC

Created attachment 338 [details]
A testcase which shows that the "; causes problems

Comment 5 Ævar Arnfjörð Bjarmason 2005-03-07 06:04:06 UTC

Comment on attachment 336 [details]
the patch against img_auth.php

marked the first one obsolete

Comment 6 Brion Vibber 2005-03-07 06:37:43 UTC

Applied to REL1_4 and HEAD.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links