Last modified: 2010-05-15 15:33:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1642 - img_auth.php bugfix
img_auth.php bugfix
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.4.x
Other All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-07 05:00 UTC by Ævar Arnfjörð Bjarmason
Modified: 2010-05-15 15:33 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
the patch against img_auth.php (617 bytes, patch)
2005-03-07 05:01 UTC, Ævar Arnfjörð Bjarmason
Details
Updated the patch (548 bytes, patch)
2005-03-07 06:02 UTC, Ævar Arnfjörð Bjarmason
Details
A testcase which shows that the "; causes problems (2.75 KB, text/plain)
2005-03-07 06:03 UTC, Ævar Arnfjörð Bjarmason
Details

Description Ævar Arnfjörð Bjarmason 2005-03-07 05:00:36 UTC
This patch fixes a small bug in img_auth.php and cleans up the code by avoiding
a needless variable which makes it harder to understand.
Comment 1 Ævar Arnfjörð Bjarmason 2005-03-07 05:01:18 UTC
Created attachment 336 [details]
the patch against img_auth.php
Comment 2 Brion Vibber 2005-03-07 05:38:00 UTC
The $endl bit is there because a file checked out on a Windows server will have CRLF line feeds instead of LF.
Comment 3 Ævar Arnfjörð Bjarmason 2005-03-07 06:02:25 UTC
Created attachment 337 [details]
Updated the patch

Despite my patch not accounting for CRLF line feeds the bug as a whole is not
INVALID, only half of it, the x-conference/x-cooltalk ice"; line still needs to
be changed to x-conference/x-cooltalk ice.
Comment 4 Ævar Arnfjörð Bjarmason 2005-03-07 06:03:37 UTC
Created attachment 338 [details]
A testcase which shows that the "; causes problems
Comment 5 Ævar Arnfjörð Bjarmason 2005-03-07 06:04:06 UTC
Comment on attachment 336 [details]
the patch against img_auth.php

marked the first one obsolete
Comment 6 Brion Vibber 2005-03-07 06:37:43 UTC
Applied to REL1_4 and HEAD.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links