Last modified: 2008-11-20 14:01:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18390, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 16390 - SubversionShell should always use --non-interactive
SubversionShell should always use --non-interactive
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Aaron Schulz
: easy, patch
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-11-19 11:25 UTC by Mormegil
Modified: 2008-11-20 14:01 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
a simple patch (938 bytes, patch)
2008-11-19 11:25 UTC, Mormegil 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Mormegil 2008-11-19 11:25:45 UTC 
Created attachment 5534 [details]
a simple patch

Since SubversionShell is now able to pass --username and --password, it is not that crucial, but still: svn should always be called with --non-interactive (which is currently missing in getFile and getDiff).

Also, SubversionShell::getExtraArgs() should not require $wgSubversionPassword, because somebody (like me in my local repository ;-) ) might have an empty password.

See the attached patch.
Comment 1 Aaron Schulz 2008-11-20 14:01:39 UTC 
Done in r43759
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links