Last modified: 2012-12-21 14:02:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18377, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16377 - Special:Newpages won't honor &hidepatrolled=1 for logged out users
Special:Newpages won't honor &hidepatrolled=1 for logged out users
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.14.x
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/w/index.php?t...
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-18 02:44 UTC by Dan Collins
Modified: 2012-12-21 14:02 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Collins 2008-11-18 02:44:13 UTC
It works on my admin account, when I log out it shows ALL new pages.
Comment 1 Dan Collins 2008-12-10 23:05:05 UTC
I didn't have time to really look into this bug, and while looking at my other recent submissions, noticed this one and had a look at it. In ./includes/specials/SpecialNewpages.php, line 139 actually actively disables this feature from being selectable. Now, I agree with line 136, which eliminates the filtering of logged-in users if only logged-in users can create pages, you'd obviously have an empty report. But the second block, lines 139-140, just prevents people who can't use patrol from being able to see what pages are patrolled. We have the 'patrollable' function that checks to see if the user should get the patrol links. At the least, allow non-patrollers to access the hidepatrolled filter as a hidden option: the code that actually blocks them from doing so, line 389, is commented "if this user cannot see patrolled edits...", but Special:Log/patrol shows the data to them anyway. There's really no reason to prevent anons from using this feature. 
Comment 2 Aaron Schulz 2009-01-15 17:14:30 UTC
What would anons do with this filter? I can think of much. Also, the filter itself isn't using an index, so it's there is a small performance issue.

That said, giving all anons (*) 'patrolmarks' should allow this.
Comment 3 Aaron Schulz 2009-09-01 21:57:28 UTC
(In reply to comment #2)
> What would anons do with this filter? I can think of much. Also, the filter
> itself isn't using an index, so it's there is a small performance issue.
> 
> That said, giving all anons (*) 'patrolmarks' should allow this.
> 

Since this arguable is clutter to IP users, I'd rather see a positive poll/discussion on this.
Comment 4 Andre Klapper 2012-12-21 14:02:02 UTC
(In reply to comment #3)
> Since this arguable is clutter to IP users, I'd rather see a positive
> poll/discussion on this.

[Removing RESOLVED LATER as discussed in http://lists.wikimedia.org/pipermail/wikitech-l/2012-November/064240.html and closing as WONTFIX as per comment 3.]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links