Last modified: 2008-11-18 01:03:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18370, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 16370 - Do not add .fr-hiddenform to #mw-reviewform on diffs for not yet marked pages


Summary:	Do not add .fr-hiddenform to #mw-reviewform on diffs for not yet marked pages

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	FlaggedRevs (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement with 1 vote (vote)
Target Milestone:	---
Assigned To:	Aaron Schulz

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-11-17 19:41 UTC by Melancholie
Modified:	2008-11-18 01:03 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Melancholie 2008-11-17 19:41:26 UTC

Do not add .fr-hiddenform to #mw-reviewform on diffs for not yet marked pages.

If a page has not yet been flagged at all the source code contains:
<form method="post" action="/w/index.php?title=Spezial:Versionsprüfung&amp;action=submit" id="mw-reviewform" class="fr-hiddenform">

No form at all is shown. No patrolling is possible. You first have to visit the plain article to get a form.

Why .fr-hiddenform is not needed at all:
If comparing two revisions, you also see the content of the revision you are going to flag. So you even see *more* than on plain view. You see the article plus what exactly has been changed. Even a diff to the current (cur) revision does not show a fr-form (as .fr-hiddenform hides it). Remove .fr-hiddenform for diffs, as diffs are even better than plain or oldid views!

BTW: That's pretty confusing for those who are used to the old patrolling feature behaviour (&rcid=... > mark as patrolled, done).

Comment 1 Aaron Schulz 2008-11-17 22:24:49 UTC

.fr-hiddenform is a compromise requested in another, closed, bug.

Also, some people have diffonly on, so they cannot see the content below diffs.

Comment 2 Melancholie 2008-11-17 23:31:10 UTC

For diffs with &diffonly=1 in URL no review form at all is in source code!

Again, on diff views you even see *more* than on plain/oldid views.
Do you still know that bug ID? Seems odd to me.

Comment 3 Aaron Schulz 2008-11-17 23:48:55 UTC

(In reply to comment #2)
> For diffs with &diffonly=1 in URL no review form at all is in source code!
> 
> Again, on diff views you even see *more* than on plain/oldid views.
> Do you still know that bug ID? Seems odd to me.
> 

Bug 14055

Comment 4 Melancholie 2008-11-18 00:22:16 UTC

Thanks, but that bug is about not showing the #mw-revisiontag-edit box on edit previews.
This is about showing #mw-reviewform on diffs for sighters.

Comment 5 Aaron Schulz 2008-11-18 00:49:12 UTC

(In reply to comment #4)
> Thanks, but that bug is about not showing the #mw-revisiontag-edit box on edit
> previews.
> This is about showing #mw-reviewform on diffs for sighters.
> 

Seems to also be about other things too, though I can't really tell what.

Comment 6 Aaron Schulz 2008-11-18 00:57:17 UTC

CSS there is not used as of r43652.

Comment 7 Melancholie 2008-11-18 01:03:08 UTC

Thanks.
Just let's hope it wasn't any workaround for something else ;-)

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links