Wikimedia Bugzilla is closed!

Hi,

I installed ConfirmAccount (1.46) on a wiki (1.14alpha (r43514)). In LocalSettings.php I have 

 $wgAccountRequestToS = false;

The Special:RequestAccount form looks bad because there is this third fieldset with the legend "Terms of Service" and nothing inside it. Because the fieldset doesn't have an id I can't hide it with CSS. (Note: Would be nice to add some CSS ids generally. :))

But this can be fixed by just moving three lines:

                if( $wgAccountRequestToS ) {
                $form .= '<fieldset>';
                $form .= '<legend>' . wfMsgHtml('requestaccount-leg-tos') . '</legend>';

                        $form .= "<p>".Xml::check( 'wpToS', $this->mToS, array('id' => 'wpToS') ).
                                ' <label for="wpToS">'.wfMsgExt( 'requestaccount-tos', array('parseinline') )."</label></p>\n";
                $form .= '</fieldset>';
                }

Currently the fieldset and legend lines are outside the if block. They just need to be moved inside it. Then it's all good.


PS> ConfirmAccount is missing from the Bugzilla list.