Last modified: 2008-11-17 21:39:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18361, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 16361 - Add user and password globals so that those using SubversionShell and closed svn can see diffs
Add user and password globals so that those using SubversionShell and closed ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Ryan Schmidt
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-11-16 17:51 UTC by Ryan Schmidt
Modified: 2008-11-17 21:39 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
patch to add these two globals (2.56 KB, patch)
2008-11-16 17:53 UTC, Ryan Schmidt 		Details
Moving member variables to a private member method instead (2.76 KB, patch)
2008-11-17 04:21 UTC, Ryan Schmidt 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Ryan Schmidt 2008-11-16 17:51:36 UTC 
The attached patch adds two globals $wgSubversionUser and $wgSubversionPassword that allow people using SubversionShell with a closed svn to still view diffs, etc. with Special:Code.

Details:
$wgSubversionUser (mixed): String of the username needed to access svn, or false if not needed (default false)
$wgSubversionPassword (mixed): String of the password needed to access svn, or false if not needed (default false)

Both of the above globals are properly escaped before being passed into the shell
Comment 1 Ryan Schmidt 2008-11-16 17:53:50 UTC 
Created attachment 5529 [details]
patch to add these two globals
Comment 2 Ryan Schmidt 2008-11-17 04:21:11 UTC 
Created attachment 5530 [details]
Moving member variables to a private member method instead

per suggestion from brion on IRC
Comment 3 Ryan Schmidt 2008-11-17 21:39:43 UTC 
fixed in r43641
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links