Last modified: 2010-06-15 13:48:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18356, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16356 - broken interwikiprefix
broken interwikiprefix
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Chad H.
http://test.wikipedia.org/wiki/Interw...
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-15 21:47 UTC by Umherirrender
Modified: 2010-06-15 13:48 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch, to show what is the problem (870 bytes, patch)
2010-03-26 19:25 UTC, Umherirrender
Details

Description Umherirrender 2008-11-15 21:47:01 UTC
The follow prefixes are define in "interwiki map" with space or non-ASCII-Letter, but doesn't work, see URL:
*[[osi reference model:]]
*[[zzz wiki:]]
*[[Ĉej:]]

The follow prefix is define with underline and works:
*[[doom_wiki:]]

(based on: http://download.wikimedia.org/dewiki/20081011/dewiki-20081011-interwiki.sql and http://de.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=interwikimap)

Must the definition in [[meta:interwiki map]] are urlencode? In my opinion it is better, wenn the script can do this or MediaWiki can work without needing of urlencode in interwiki-table.
Comment 1 Umherirrender 2010-03-26 19:25:16 UTC
Created attachment 7246 [details]
patch, to show what is the problem

The problem is, that the input from [[m:Interwiki map]] in dumpInterwiki.inc is not normalized the same way as in Interwiki::fetch().

Interwiki::fetch use $wgContLang->lc().
dumpInterwiki.inc use strtolower, this fails with mulitbytes, so the interwiki [[Ĉej:]] is not linked korrekt.

All datatables store the titlekeys with underscores, so spaces should replaced by underscores.
Comment 2 Derk-Jan Hartman 2010-06-15 13:33:56 UTC
This patch looks good to me, but i have little experience in this area. Adding review keyword and setting to maintenance script category.
Comment 3 Chad H. 2010-06-15 13:39:07 UTC
Looks fine to me, feel free to apply.
Comment 4 Derk-Jan Hartman 2010-06-15 13:48:14 UTC
Applied in r68073

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links