Last modified: 2008-11-15 02:52:36 UTC
This is a similar request to previous bugs, but not identical, or at least the resolution to those bugs was not the desired one. The review form is not shown when following diff links that end in "diffonly=1", or if the user has opted in their preferences not to see diffs. I realise that the links the user is most likely to follow now force "diffonly=0" to work around this, but that's not really much help. The review form should always be shown. If users want an option not to show that either, that can be made a separate user preference. The reason this is particularly desired in my case is that it makes sighting of pages unnecessarily resource-heavy -- the only way to do it is to load the whole page content and diff; loading the diff only would make things easier. Of course an API module would be even better (that's bug 16278), but I'm assuming here that that isn't going to happen yet.
It does show, but only on a diff-to-stable, not just any diff.
...but for (In reply to comment #1) > It does show, but only on a diff-to-stable, not just any diff. > ...but for diffonly=0, it *does* show on any diff. And what am I supposed to do if there is no stable version of the page yet?
(In reply to comment #2) > ...but for (In reply to comment #1) > > It does show, but only on a diff-to-stable, not just any diff. > > > > ...but for diffonly=0, it *does* show on any diff. And what am I supposed to do > if there is no stable version of the page yet? > Then view the page normally (non-diff). Part of the problem with adding a form to all diffs with diffonly=0 is that it requires parsing the rightmost version, which would not normally have happened. This takes time, which defeats some of the purpose of diffonly (speed). When the user has the content displayed below already, adding the form doesn't slow anything down much, since it was already parsed.
