Last modified: 2011-01-25 01:47:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18335, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16335 - Add magic word __NONEWSECTIONLINK__
Add magic word __NONEWSECTIONLINK__
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.14.x
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-13 19:25 UTC by Mike.lifeguard
Modified: 2011-01-25 01:47 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (4.58 KB, patch)
2009-01-16 00:20 UTC, jopiswezggzmw
Details

Description Mike.lifeguard 2008-11-13 19:25:10 UTC
This would have the opposite effect of __NEWSECTIONLINK__ -- force hiding of the new section link. This is useful for cases where we want to force users to use an inputbox or link with editintro/preload instead of a vanilla new section link.
Comment 1 jopiswezggzmw 2009-01-16 00:20:51 UTC
Created attachment 5680 [details]
Proposed patch

Not sure if this is the *best* way to do it but it works.

Turns out setting setNewSection to false doesn't work since the $istalk if statement in SkinTemplate.php overrides it.
Comment 2 jopiswezggzmw 2009-01-27 01:16:46 UTC
[02:55:34] <aiml>	Is there anything wrong with https://bugzilla.wikimedia.org/attachment.cgi?id=5680&action=diff ?
[03:20:43] <TimStarling>	aiml: looks fine to me

[03:35:47] <aiml>	TimStarling: Cool thanks, any chance of getting it committed? Or what's the usual process on that?
[03:37:12] <Marybelle>	aiml: Bugging a committer in here.
[03:37:52] <werdnum>	over and over again

^ Tried that and it didn't work so changed to reviewed instead.
Comment 3 jopiswezggzmw 2009-02-18 06:51:24 UTC
Any chance of this ever getting committed?
Comment 4 Brion Vibber 2009-02-19 22:15:17 UTC
Looks good to me, applied in r47522 for 1.15 dev trunk.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links