Last modified: 2011-07-20 20:48:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18318, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 16318 - PHP warning on SortPermissions.php
PHP warning on SortPermissions.php
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
unspecified
All Linux
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-11-12 13:21 UTC by m.bemmerl
Modified: 2011-07-20 20:48 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch that does not call strpos() on an empty $wgScriptPath (695 bytes, patch)
2008-11-12 13:21 UTC, m.bemmerl 		Details
Replacing $inc by $dir (475 bytes, patch)
2008-11-12 14:43 UTC, m.bemmerl 		Details
Add an attachment (proposed patch, testcase, etc.)

Description m.bemmerl 2008-11-12 13:21:16 UTC 
Created attachment 5521 [details]
Patch that does not call strpos() on an empty $wgScriptPath

I'm getting a PHP warning on calling http://wiki.example.com/index.php/Special:SortPermissions:

Warning:  strpos() [function.strpos]: Empty delimiter. in /srv/www/htdocs/mediawiki-1.13.2/extensions/GroupPermissionsManager/SortPermissions.php on line 34

I think the cause for this is (as you see in the URL above) a empty $wgScriptPath. I attached a patch, that does not call strpos when $wgScriptPath is empty.
Comment 1 X! 2008-11-12 14:30:47 UTC 
Fixed in r43412.
Comment 2 m.bemmerl 2008-11-12 14:42:30 UTC 
In r43412 you forgot to replace $inc by $dir on line 38. See my patch.
Comment 3 m.bemmerl 2008-11-12 14:43:08 UTC 
Created attachment 5523 [details]
Replacing $inc by $dir
Comment 4 X! 2008-11-12 18:31:32 UTC 
Fixed in r43417
Comment 5 Mark A. Hershberger 2011-07-20 20:48:29 UTC 
Marked invalid since the entire extension was removed from Bz at the request of the Ryan who said the extension was no longer under development.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links