Last modified: 2009-09-19 23:38:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18311, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16311 - Make recent change flags abbreviations instead of spans
Make recent change flags abbreviations instead of spans
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
unspecified
All All
: Low enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Special:...
: patch
: 15871 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-11 13:10 UTC by Robin Whittleton
Modified: 2009-09-19 23:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (2.15 KB, patch)
2008-11-11 13:11 UTC, Robin Whittleton
Details
Updated patch (3.58 KB, patch)
2009-07-29 19:56 UTC, Chad H.
Details

Description Robin Whittleton 2008-11-11 13:10:20 UTC
On watchlists (and other places?) each recent edit can have a flag attached to it to indicated whether it was a minor edit, bot edit, etc.. These flags are very cryptic unless you know enough to check the class name. The following patch changes them to proper <acronym> elements and gives them a title pulled from the localised messages file. I haven't contributed to Mediawiki before so I've no idea how difficult it is to push through a change that needs localising, but hey, let me know.

So is this a wanted feature? What would it take to get it pushed in?
Comment 1 Robin Whittleton 2008-11-11 13:11:02 UTC
Created attachment 5519 [details]
Proposed patch
Comment 2 Aaron Schulz 2009-01-02 21:50:11 UTC
Please update the patch. It doesn't apply.
Comment 3 Robin Whittleton 2009-01-03 00:41:39 UTC
Hi Aaron, thanks for looking at this. I've just grabbed a fresh SVN pull of trunk and the existing patch seems to apply fine without problems?

--------------
robin@jackle:~/Code/mediawiki-phase3$ patch -p0 < 16331.patch 
patching file includes/ChangesList.php
patching file languages/messages/MessagesEn.php
Hunk #1 succeeded at 1591 (offset -131 lines).
--------------

Bear with me please if I'm doing something wrong, like I said I'm not particularly experienced here. Just scratching an itch :)
Comment 4 Aaron Schulz 2009-01-03 05:18:25 UTC
1.14a?
Comment 5 Robin Whittleton 2009-01-03 15:51:08 UTC
hah, sorry Aaron, I've realised I made 2 mistakes:

1) did my work on branch, not trunk
2) assumed that the patch was simple enough that I could chuck it up without fully testing

I've spent the morning getting a working mediawiki install on my laptop, then recoiling in horror at the extent of the problem I've chosen to take on :) I'll keep on working on a revised + working patch until I've got something half-decent to put up.
Comment 6 Siebrand Mazeland 2009-02-02 13:32:38 UTC
Changed component to "RecentChanges"
Comment 7 Niklas Laxström 2009-05-23 09:05:13 UTC
New patch coming?
Comment 8 Chad H. 2009-07-29 19:56:36 UTC
Created attachment 6401 [details]
Updated patch

This patch is against r53927, should apply cleanly to HEAD. Updated all instances of boteditletter|minoreditletter|newpageletter to use <abbr> instead of <span>. Kept class="minor" or class="bot", as appropriate.
Comment 9 Chad H. 2009-07-29 22:16:06 UTC
Done in r53975. Made them <abbr> instead of <acronym>, as we're not really indicating acronyms here, they're abbreviations. Plus <acronym> isn't allowed in HTML5.
Comment 10 Chris Eagle 2009-09-19 23:38:30 UTC
*** Bug 15871 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links