Last modified: 2009-04-28 01:12:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18264, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 16264 - Provide escaped parameters for Antispoof messages
Provide escaped parameters for Antispoof messages
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AntiSpoof (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/MediaWik...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-11-06 19:31 UTC by RockMFR
Modified: 2009-04-28 01:12 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description RockMFR 2008-11-06 19:31:15 UTC 
The $1 and $2 parameters of MediaWiki:Antispoof-name-conflict currently are not escaped, so they cannot be used in links (e.g., '<a href="$1">foo</a>') without creating an XSS hole (it is possible to create a username that can exploit this hole). This was previously being done on enwiki but I have removed the links for now.

Either escaped versions of these parameters need to be provided, or this message needs to be changed to use wiki markup.
Comment 1 RockMFR 2008-11-06 19:58:21 UTC 
Actually, I see that the code has changed since I last updated my local copy. The relevant messages are antispoof-conflict-top and antispoof-conflict-item.
Comment 2 Chad H. 2009-04-28 01:12:06 UTC 
Fixed in r49990. Only escaped the invalid username since the spoof matches should already be normalized (since they're existing users).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links