Last modified: 2010-10-29 19:31:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18213, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16213 - hyphen-minus is unreadable
hyphen-minus is unreadable
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ConfirmEdit (CAPTCHA extension) (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-01 16:26 UTC by Christopher Yeleighton
Modified: 2010-10-29 19:31 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christopher Yeleighton 2008-11-01 16:26:25 UTC
It is hard to tell hyphen-minus from multiplication dot.
I would recommend using − instead for presentation.

    function SimpleCaptcha.getCaptcha() {
        $a = mt_rand(0, 100);
        $b = mt_rand(0, 10);
        $op = mt_rand(0, 1) ? '+' : '−';

        $test = "$a $op $b";
        $answer = ($op == '+') ? ($a + $b) : ($a - $b);
        return array('question' => $test, 'answer' => $answer);
    }

Alternatively, the equation should be typeset in a monospaced font style.
Comment 1 Siebrand Mazeland 2009-02-15 00:47:25 UTC
Please provide a patch.
Comment 2 Christopher Yeleighton 2009-02-15 23:33:10 UTC
I do not have a development environment for MediaWiki (in particular, I do not have Subversion).  I hope replacing that '-' with '−' is simple enough for any developer.
Do not take it as a refusal.  I just doubt I will be able to set things up quickly.
Comment 3 Christopher Yeleighton 2009-02-15 23:40:27 UTC
76c76
<               $op = mt_rand(0, 1) ? '+' : '-';
---
>               $op = mt_rand(0, 1) ? '+' : '&minus;';

(Untested.)
Comment 4 Siebrand Mazeland 2009-02-16 00:00:02 UTC
Please *do* test.
Comment 5 Christopher Yeleighton 2009-02-17 10:26:05 UTC
Index: extensions/ConfirmEdit/ConfirmEdit_body.php
===================================================================
--- extensions/ConfirmEdit/ConfirmEdit_body.php (revision 47356)
+++ extensions/ConfirmEdit/ConfirmEdit_body.php (working copy)
@@ -73,7 +73,7 @@
        function getCaptcha() {
                $a = mt_rand(0, 100);
                $b = mt_rand(0, 10);
-               $op = mt_rand(0, 1) ? '+' : '-';
+               $op = mt_rand(0, 1) ? '+' : '&minus;';

                $test = "$a $op $b";
                $answer = ($op == '+') ? ($a + $b) : ($a - $b);

(This is subversion diff this time, still struggling with how to test it)
Comment 6 Christopher Yeleighton 2009-02-28 17:06:35 UTC
Test done, result positive.
Comment 7 Derk-Jan Hartman 2010-10-29 19:31:57 UTC
Fixed in r75667.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links