Last modified: 2008-11-02 18:23:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18195, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16195 - query-continue incorrect for usercontribs
query-continue incorrect for usercontribs
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-31 02:39 UTC by Bruno
Modified: 2008-11-02 18:23 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bruno 2008-10-31 02:39:18 UTC
I just noticed that running a list=usercontribs query returns a totally wrong value for query-continue.  at the moment, you get:

<query-continue>
    <usercontribs ucstart="timestamp" />
</query-continue>

when you really ought to be getting:

<query-continue>
    <usercontribs uccontinue="timestamp" />
</query-continue>

the timestamp value might be the correct value (I'll try that and see) but the parameter name is wrong.  it even says this in the docs, incidentally...
Comment 1 Bruno 2008-10-31 03:01:23 UTC
addendum:  I don't think the timestamp returned is the correct value for uccontinue.  don't know what it is, but it doesn't seem to have the desired effect.
Comment 2 Roan Kattouw 2008-10-31 12:08:36 UTC
This is correct behavior.

When listing contributions for just one user, usercontribs sets ucstart=timestamp as its query-continue value. When listing contributions for multiple users (with ucuserprefix or multiple values for ucuser), usercontribs sets uccontinue=username|timestamp as its query-continue value.

It's perfectly legal for a module to use different query-continue parameters in different situations: clients are supposed to just do what query-continue says. Of course this kind of behavior can be confusing; usercontribs is the only module to do this, and was only recently updated to do so.
Comment 3 Bruno 2008-11-01 03:41:58 UTC
Follow-up question.  just thinking programmatically here, but if a script
sends both the 'ucstart' and 'uccontinue' parameters, does the latter 
obviate the former?  basically I want to know if I need to remove the 
ucstart parameter when I continue a query with uccontinue.
Comment 4 Roan Kattouw 2008-11-01 07:58:44 UTC
(In reply to comment #3)
> Follow-up question.  just thinking programmatically here, but if a script
> sends both the 'ucstart' and 'uccontinue' parameters, does the latter 
> obviate the former?  basically I want to know if I need to remove the 
> ucstart parameter when I continue a query with uccontinue.
> 

Neither overrides the other, the most restrictive one applies. In real-life situations, uccontinue will always be more restrictive than ucstart, so you *could* leave out ucstart when you've got a uccontinue, but you don't *have* to.
Comment 5 Bruno 2008-11-01 08:59:06 UTC
well, it's an issue of a single line that messes up my beautiful, generalized code.

In other words, you're KILLING me!  lol 

=)

Comment 6 Roan Kattouw 2008-11-01 18:16:18 UTC
(In reply to comment #5)
> well, it's an issue of a single line that messes up my beautiful, generalized
> code.
> 
> In other words, you're KILLING me!  lol 
> 
> =)
> 

It shouldn't mess up sane code. Sane code would just blindly do whatever query-continue says and not modify the original request in any other way. That always works, and always will.
Comment 7 Bruno 2008-11-02 18:23:51 UTC
no worries, I was just joking around.  :-)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links