Last modified: 2010-05-15 15:34:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1617 - Incorrect login message when using AuthPlugin
Incorrect login message when using AuthPlugin
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.4.x
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-02 12:48 UTC by Mark Bergsma
Modified: 2010-05-15 15:34 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to fix the bug (1.23 KB, patch)
2005-03-02 12:50 UTC, Mark Bergsma
Details

Description Mark Bergsma 2005-03-02 12:48:23 UTC
When using AuthPlugin and entering an existing username with a wrong password,
MediaWiki responds with an error message stating that the given username does
not exist. This is incorrect and confusing.

Patch to fix it:

--- SpecialUserlogin.php.orig   Wed Mar  2 12:38:07 2005
+++ SpecialUserlogin.php        Wed Mar  2 12:42:50 2005
@@ -248,10 +248,14 @@
                         * automatically create a new account for users that
                         * are externally defined but have not yet logged in.
                         */
-                       if( $wgAuth->autoCreate() &&
-                           $wgAuth->userExists( $u->getName() ) &&
-                           $wgAuth->authenticate( $u->getName(),
$this->mPassword ) ) {
-                           $u =& $this->initUser( $u );
+                       if( $wgAuth->autoCreate() && $wgAuth->userExists(
$u->getName() ) ) {
+                               if( $wgAuth->authenticate( $u->getName(),
$this->mPassword ) ) {
+                                       $u =& $this->initUser( $u );
+                               }
+                               else {
+                                       $this->mainLoginForm( wfMsg(
'wrongpassword' ) );
+                                       return;
+                               }
                        } else {
                                $this->mainLoginForm( wfMsg( 'nosuchuser',
$u->getName() ) );
                                return;
Comment 1 Mark Bergsma 2005-03-02 12:50:42 UTC
Created attachment 325 [details]
Patch to fix the bug

The non munged version...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links