Last modified: 2008-10-31 19:01:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18153, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16153 - Drafts should use core mechanism for configuring accesskeys
Drafts should use core mechanism for configuring accesskeys
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Drafts (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-28 00:49 UTC by Aryeh Gregor (not reading bugmail, please e-mail directly)
Modified: 2008-10-31 19:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (may have some issues, see text) (6.37 KB, patch)
2008-10-28 00:49 UTC, Aryeh Gregor (not reading bugmail, please e-mail directly)
Details

Description Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-10-28 00:49:43 UTC
Created attachment 5480 [details]
Proposed patch (may have some issues, see text)

See bug 16089.  The solution to that, r42689, introduced a config variable.  This is inconsistent with core, which uses system messages.  It also doesn't make use of the magical formats that cause wikibits.js to append " [alt-shift-d]" or similar to the tooltip.

The attached patch should rectify this, but I wasn't able to test it since I don't have Drafts installed.  Also, I'm not sure if it's okay for an extension to use messages that aren't prefixed with the extension name -- if not, some tweaks will be needed to core to allow prefixed messages in Linker::titleAttrib() and Linker::accesskey().

Clearly, if the patch is used and more localizations have been added in the meantime, the message keys for the new localizations need to be changed too.
Comment 1 Raimond Spekking 2008-10-31 19:01:58 UTC
Fixed with r42891/r42932.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links