Last modified: 2014-11-18 18:07:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18084, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16084 - Default memory limit should be increased
Default memory limit should be increased
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.14.x
PC Linux
: Normal enhancement with 2 votes (vote)
: ---
Assigned To: Emufarmers
: patch, patch-reviewed
: 19663 19775 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-24 00:58 UTC by Jay MacDonald
Modified: 2014-11-18 18:07 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
proposed patch (1.01 KB, patch)
2008-10-24 13:13 UTC, Jay MacDonald
Details
Adds a run-time check (1.82 KB, patch)
2009-07-17 02:53 UTC, Emufarmers
Details
Now with a global variable, $wgMemoryLimit, and a global function for parsing PHP's memory limits (3.08 KB, patch)
2009-08-01 02:21 UTC, Emufarmers
Details
Fix the function to handle input better (728 bytes, patch)
2009-08-04 03:14 UTC, OverlordQ
Details

Description Jay MacDonald 2008-10-24 00:58:30 UTC
Fatal error: Allowed memory size of 20971520 bytes exhausted (tried to allocate 181066 bytes) in /home/jay/public_html/phase3/includes/specials/SpecialAllmessages.php on line 208

Looks like the 20M or so isn't enough.
Comment 1 Jay MacDonald 2008-10-24 03:36:29 UTC
I think the default memory limit should be increased to something around 50-100 MB. What do you lot think?
Comment 2 Mike.lifeguard 2008-10-24 03:40:33 UTC
Hopefully a better summary
Comment 3 Jay MacDonald 2008-10-24 13:13:30 UTC
Created attachment 5462 [details]
proposed patch

I propose a 50M memory limit as a default. Patch included.
Comment 4 Aaron Schulz 2009-01-03 06:00:47 UTC
Done in r45361
Comment 5 Brion Vibber 2009-01-07 01:37:31 UTC
This still sucks horribly; it really should be done at run time, not at install time.
Comment 6 Brion Vibber 2009-01-07 01:43:23 UTC
Reverting for now in r45475

The logic is wrong and will fail to raise the limit to the new limit if the server's default is between 20 and 50. Further, the whole logic is crappy; we should be doing the check at runtime rather than at install time, since the server's settings may change after we install.
Comment 7 Chad H. 2009-07-17 01:09:18 UTC
*** Bug 19775 has been marked as a duplicate of this bug. ***
Comment 8 Emufarmers 2009-07-17 02:53:52 UTC
Created attachment 6350 [details]
Adds a run-time check

Checks in Setup.php that the memory limit is at least 50M  and raises it otherwise.  The installer will still raise the memory limit for its own purposes but will not write anything to LocalSettings.php.
Comment 9 Niklas Laxström 2009-07-17 06:05:24 UTC
*** Bug 19663 has been marked as a duplicate of this bug. ***
Comment 10 Chad H. 2009-07-23 18:51:22 UTC
Patch looks ok by me. I'll commit this evening.
Comment 11 Emufarmers 2009-08-01 02:21:53 UTC
Created attachment 6409 [details]
Now with a global variable, $wgMemoryLimit, and a global function for parsing PHP's memory limits
Comment 12 Chad H. 2009-08-04 02:48:14 UTC
Patch applied in r54339
Comment 13 OverlordQ 2009-08-04 03:14:43 UTC
Created attachment 6417 [details]
Fix the function to handle input better

Given patch will actually lower memory usage in cases where somebody uses the other shorthand forms.
Comment 14 Chad H. 2009-08-04 11:18:44 UTC
Done in r54356.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links