Last modified: 2013-06-18 15:54:03 UTC
http://en.wikipedia.org/w/index.php?title=Special:RenameUser Mediawiki should ignore the case of the first letter of the current username. Too many false positives reported when renaming.
I just added a fix to the CHU template that automatically uppercases the names onwiki.
False positive whats? Note that Special:RenameUser needs to be able to take lowercase usernames as input on wikis supporting lowercase page titles, since old user accounts may have to be fixed.
Fixed in r45331. RenameUser was force-capitalizing all target usernames, even if the wiki allows lowercase names. Allowing Title to handle the normalization for us fixes this.
Self-reverted in r16075.
That should be r45332. 16075 is this bug's number. :) We should check for the lowercase username first, and if that doesn't exist try the uppercase one.
(In reply to comment #2) > False positive whats? > > Note that Special:RenameUser needs to be able to take lowercase usernames as > input on wikis supporting lowercase page titles, since old user accounts may > have to be fixed. > Agreed. There shouldn't be anything wrong with how RenameUser does things at the moment. We accept upper or lower-case user names (as some lower-cased ones could still exist and need renaming). Output should always be first-letter upper-cased, as User is hardcoded to only allow first-letter upper-cased names. The current behavior is exactly this, and I don't see any reason it should change. Pending more clarification as to what the actual issue is, I suggest WORKSFORME, as this is all designed as intended.
Changing bug summary to remove weird jargon.
Clarifying subject in summary.
The comment message of r45332 mentioned in comment 4 states "Because User is hardcoded to only allow upper-cased-first usernames, this breaks login and pretty much everything in the User class. The (coming?) changes to $wgCapitalLinks should fix this." Has that ever happened, and if so, is this still an issue?
(In reply to comment #9) > The comment message of r45332 mentioned in comment 4 states "Because User is > hardcoded to only allow upper-cased-first usernames, this breaks login and > pretty much everything in the User class. The (coming?) changes to > $wgCapitalLinks should fix this." > > Has that ever happened, and if so, is this still an issue? It shouldn't be an issue anymore--unless wikis with $wgCapitalLinks = false are still wanting lowercased usernames. When we did the $wgCapitalLink(Override)s work, we forced NS_USER to always be ucfirst and the User class stayed the same. There might be some issues with dangling lowercased pages in NS_USER(_TALK) from wikis with $wgCapitalLinks = false that existed before the fixes--but that wouldn't be part of this bug.
(Pressed enter too soon) So yeah: I'd be inclined to mark this FIXED, but someone should definitely test it out because it's been *ages* since I worked on this.
Marking resolved based on comment 11.
