Last modified: 2014-11-17 10:36:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T18000, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 16000 - Massive diffs should be hidden until user confirms they want it loaded
Massive diffs should be hidden until user confirms they want it loaded
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Low enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-16 00:56 UTC by Mike.lifeguard
Modified: 2014-11-17 10:36 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mike.lifeguard 2008-10-16 00:56:07 UTC
When the diff is /massive/ (ie the bottle table - not sure what a good size here would be) omit the diff until the user confirms they want it (perhaps load the diff w/ AJAX) This should apply to everywhere you see diffs. The main challenge, I imagine, will be figuring out before render how big the diff will be. Even if the server must render the diff, it will be worth not sending it along to the user unless they want it. Most such diffs are likely clear vandalism, and nobody will care to see such diffs. The remainder of actually-should-be-seen diffs can still be seen after confirming. This will help keep users' browsers from crashing after rollback of such vandalism, and inadvertently requesting diffs which are huge. A simple "This diff is X KB, and might crash or bog down your browser, do you really want to see it?" will be lovely.
Comment 1 Chad H. 2008-10-16 12:51:21 UTC
Seems like an extra step without any real benefit. 

1) Select two revs on a page
2) Press "Compare selected version"
   Diff is over X bytes, are you really sure you want to view it?
3) Press ok.

Seems like it might bug a lot of users, and I'm hesitant to throw a new userpref in for this.
Comment 2 Dan Garry 2014-02-07 19:28:20 UTC
Changing to RESOLVED WONTFIX per Chad.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links