Last modified: 2011-03-13 18:05:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17991, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15991 - userWasLastToEdit function's revisions limit shouldn't be hard-coded
userWasLastToEdit function's revisions limit shouldn't be hard-coded
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.14.x
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-15 09:29 UTC by NSK Nikolaos S. Karastathis
Modified: 2011-03-13 18:05 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description NSK Nikolaos S. Karastathis 2008-10-15 09:29:10 UTC
r42034 added the userWasLastToEdit function in trunk/phase3/includes/EditPage.php	(revision 42034), with a hard-coded revisions limit of 20:

+	 * Check if no edits were made by other users since
+	 * the time a user started editing the page. Limit to
+	 * 20 revisions for the sake of sanity.
+	 */
+	protected function userWasLastToEdit( $id, $edittime ) {
[...]
+			array( 'ORDER BY' => 'rev_timestamp ASC', 'LIMIT' => 20 ) );


I would like that revisions limit, which is currently hard-coded to 20, to become customisable to better suit wikis with different edit cultures.
Comment 1 Aaron Schulz 2008-10-15 14:24:42 UTC
Limit bumped to 50. This is there for performance only, and it just a maximum plausible value. No need for a new config variable.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links