Last modified: 2008-11-14 13:05:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17971, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15971 - CategoryTreeItem: twice as many TABs for text browser users
CategoryTreeItem: twice as many TABs for text browser users
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CategoryTree (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/wiki/Cat...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-13 21:02 UTC by Dan Jacobson
Modified: 2008-11-14 13:05 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Jacobson 2008-10-13 21:02:02 UTC
Gentlemen, on the above URL let's examine the links for e.g., "[+] Buses by continent (6 C)"

 <div class="CategoryTreeItem">
  <span class="CategoryTreeBullet"><a href=
  "/wiki/Category:Buses_by_continent" class="CategoryTreeToggle"
onclick="this.href='javascript:void(0)';
   categoryTreeExpandNode('Buses_by_continent',{&quot;mode&quot;:0,&quot;hideprefix&quot;:20,&quot;showcount&quot;:true,&quot;namespaces&quot;:false},this);"
title="expand">[<b>+</b>]</a></span> <a class="CategoryTreeLabel
   CategoryTreeLabelNs14 CategoryTreeLabelCategory" href=
  "/wiki/Category:Buses_by_continent">Buses by continent</a>
  <span title="contains 6 subcategories, 0 pages, and 0 files">(6
  C)</span>
 </div>

The problem is, if the user is using a text browser or any other
situation where he is not head over heels about turning on javascript,
he just ends up with pairs of the same hyperlink.

Therefore TABing through a page, he has to hit twice as many tabs to
get to where he wants, to step over what are now pairs of the same
link.

Therefore please make your javascript bonuses only affect users who
are using javascript, and not have any negative side effects on those
who don't. (Accessibility impact.)

One approach would be to rewrite so the whole first link only appears
at all if the user has javascript turned on.

Or maybe a user preference: enable javascript extensions (on by
default)...

Anyway, all I know is please test these things in text browsers next
time first.
Comment 1 Daniel Kinzler 2008-10-28 09:42:45 UTC
To be honest, I do not recall why I made the [+] a hyperlink at all. It could just be a span with an onclick handler, right? That would solve the problem.

Would that have some implication I'm not thinking of right now?
Comment 2 Daniel Kinzler 2008-11-14 13:05:27 UTC
Fixed in r43492

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links