Last modified: 2008-10-12 17:08:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17952, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15952 - LocalFile::getSha1() updates the sha1 column even in readonly
LocalFile::getSha1() updates the sha1 column even in readonly
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.14.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-12 17:00 UTC by Platonides
Modified: 2008-10-12 17:08 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Platonides 2008-10-12 17:00:42 UTC
LocalFile::getHash() updates the sha1 column if it's not present, but it does so even if the wiki is in read only, with the consequent db Exception being thrown.

#0 /usr/local/apache/common-local/php-1.5/includes/db/Database.php(574): Database->reportQueryError('Can't execute t...', 1223, 'UPDATE  `image`...', 'LocalFile::getS...', false)
#1 /usr/local/apache/common-local/php-1.5/includes/db/Database.php(1330): Database->query('UPDATE  `image`...', 'LocalFile::getS...')
#2 /usr/local/apache/common-local/php-1.5/includes/filerepo/LocalFile.php(1146): Database->update('image', Array, Array, 'LocalFile::getS...')
#3 /usr/local/apache/common-local/php-1.5/includes/api/ApiQueryImageInfo.php(140): LocalFile->getSha1()
#4 /usr/local/apache/common-local/php-1.5/includes/api/ApiQueryImageInfo.php(85): ApiQueryImageInfo::getInfo(Object(OldLocalFile), Array, Object(ApiResult))
#5 /usr/local/apache/common-local/php-1.5/includes/api/ApiQuery.php(212): ApiQueryImageInfo->execute()
#6 /usr/local/apache/common-local/php-1.5/includes/api/ApiMain.php(422): ApiQuery->execute()
#7 /usr/local/apache/common-local/php-1.5/includes/api/ApiMain.php(258): ApiMain->executeAction()
#8 /usr/local/apache/common-local/php-1.5/includes/api/ApiMain.php(242): ApiMain->executeActionWithErrorHandling()
#9 /usr/local/apache/common-local/php-1.5/api.php(77): ApiMain->execute()
#10 /usr/local/apache/common-local/live-1.5/api.php(3): require('/usr/local/apac...')
#11 {main}
Comment 1 Aaron Schulz 2008-10-12 17:08:11 UTC
Fixed in r41997

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links