Last modified: 2008-10-13 15:56:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17924, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15924 - on the form input: double urlencode problem of title
on the form input: double urlencode problem of title
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-10 08:16 UTC by Jung Gun Lim
Modified: 2008-10-13 15:56 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jung Gun Lim 2008-10-10 08:16:21 UTC
I am using SemanticForms 1.3.3 on my mediawiki 1.13.1, and the language of my site is Korean. 

I made a template creation form and try to add a page with that form, but there was a problem. In the Korean wiki, the name of the namespace 'Special' is '특수기능'. The page title '특수기능:AddPage' goes into 'title' field, url-encoded. So while running 'GET' method into the page, title field which is already url-encoded is encoded again, and it makes trouble. : 'Page not found' error occurs.

This patch should be applied to fix this problem.

<pre>
Index: includes/SF_ParserFunctions.php
===================================================================
--- includes/SF_ParserFunctions.php     (revision 810)
+++ includes/SF_ParserFunctions.php     (working copy)
@@ -154,7 +154,7 @@
        // (i.e., it's in the default URL style), add in the title as a
        // hidden value
        if (($pos = strpos($ap_url, "title=")) > -1) {
-               $str .= '                       <input type="hidden" name="title" value="' . substr($ap_url, $pos + 6) . '">' . "\n";
+               $str .= '                       <input type="hidden" name="title" value="' . urldecode(substr($ap_url, $pos + 6)) . '">' . "\n";
        }
        if ($inFormName == '') {
                $str .= sffFormDropdownHTML();
</pre>
Comment 1 Yaron Koren 2008-10-13 15:56:42 UTC
Thanks for the patch; this was fixed in version 1.3.4.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links