Last modified: 2011-04-14 15:14:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17807, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15807 - Special:ListUsers should not fetch user groups itself
Special:ListUsers should not fetch user groups itself
Status: NEW
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.14.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-02 15:16 UTC by Bryan Tong Minh
Modified: 2011-04-14 15:14 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bryan Tong Minh 2008-10-02 15:16:45 UTC
User groups for Special:ListUsers should be fetched using User::getEffectiveGroups rather than performing the query itself, in order to give hooks that change groups the ability to do so.
Comment 1 Raimond Spekking 2009-02-18 20:47:57 UTC
From User::getEffectiveGroups:
	 * Get the list of implicit group memberships this user has.
	 * This includes all explicit groups, plus 'user' if logged in,
	 * '*' for all accounts and autopromoted groups

This is wrong as the list would depends on the group membership(s) of the requesting user.

Maybe User::getAllGroups needs a hook call instead.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links