Last modified: 2011-01-25 01:08:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17798, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15798 - global block log broken in the recent changes
global block log broken in the recent changes
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GlobalBlocking (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://meta.wikimedia.org/wiki/Specia...
:
: 15987 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-01 19:17 UTC by spacebirdy
Modified: 2011-01-25 01:08 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spacebirdy 2008-10-01 19:17:36 UTC
The global block log breaks if there is more than one action a day and if one has the enhanced rc activated.

it looks like 

|> 18:23 [Someone (2x)]

instead of 

|> 18:23 ([[m:Special:Log/gblblock|Global block log]])‎ [Someone (2x)]

Thanks in advance for Your help.
Comment 1 spacebirdy 2008-10-03 02:55:33 UTC
Also the global rights log.

Just seein this in the rc:

+-      02:17 	‎ [Someone; Someone else (2×)]

instead of

+-      02:17 	‎ (Global rights log) [Someone; Someone else (2×)]
Comment 2 Andrew Garrett 2008-10-03 02:57:26 UTC
Hmm.. both global blocks and global rights are my inventions. Did I miss something in creating a new log type?
Comment 3 spacebirdy 2008-10-15 11:07:56 UTC
*** Bug 15987 has been marked as a duplicate of this bug. ***
Comment 4 Mike.lifeguard 2008-10-15 17:32:52 UTC
(In reply to comment #2)
> Hmm.. both global blocks and global rights are my inventions. Did I miss
> something in creating a new log type?
> 

I think the logs themselves are fine, just the line you see in RC.
Comment 5 Alex Z. 2008-10-15 21:18:52 UTC
Okay, the problem with global blocking (haven't looked into global rights, probably the same thing) is that its setting the wrong combination of namespace and title in the recentchanges table:

mysql> SELECT rc_namespace,rc_title,rc_log_type FROM recentchanges WHERE rc_type = 3 ORDER BY rc_id DESC LIMIT 3;
+--------------+-------------------------------+-------------+
| rc_namespace | rc_title                      | rc_log_type |
+--------------+-------------------------------+-------------+
|            2 | 123.123.123.123               | block       |
|           -1 | Contributions/125.125.125.126 | gblblock    |
|           -1 | Contributions/125.125.125.125 | gblblock    |
+--------------+-------------------------------+-------------+

When the enhanced RC sees something in the special namespace, it assumes its going to be in the format of 'Log/type', and anything else just sets an empty string (includes/Changeslist.php Lines 431-440)

The fix would be to set the namespace to 2 like normal blocking and the title to just the username/IP address. Hopefully it can be done without breaking existing log entries.
Comment 6 Mike.lifeguard 2009-04-05 20:14:43 UTC
(In reply to comment #1)
> Also the global rights log.
> 
> Just seein this in the rc:
> 
> +-      02:17   ‎ [Someone; Someone else (2×)]
> 
> instead of
> 
> +-      02:17   ‎ (Global rights log) [Someone; Someone else (2×)]
> 

With enhanced RC, I see:
+-      21:58 	(Global block log)‎ . . [Mike.lifeguard‎; Spacebirdy‎ (2×); Drini‎ (3×); Dungodung‎ (4×); Mardetanha‎ (6×)]

So... I guess this got fixed at some point, possibly r48005?
Comment 7 Mike.lifeguard 2009-04-05 20:26:15 UTC
to test bug 18054 
Comment 8 Mike.lifeguard 2009-04-05 20:26:44 UTC
and now wikibugs should tell me it's changed to fixed...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links