Last modified: 2008-10-05 00:46:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17739, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15739 - change showcurid to show wiki url as oposed to /w/index.php...
change showcurid to show wiki url as oposed to /w/index.php...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
DynamicPageList (Other open bugs)
unspecified
All All
: Normal enhancement with 2 votes (vote)
: ---
Assigned To: Aaron Schulz
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-27 02:19 UTC by Bawolff (Brian Wolff)
Modified: 2008-10-05 00:46 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2008-09-27 02:19:13 UTC
Currently, when using showcurid=true in a DPL, it gives urls like:
http://en.wikinews.org/w/index.php?title=CanadaVOTES:_Libertarian_Kevin_Stricker_running_in_Saskatoon%E2%80%94Rosetown%E2%80%94Biggar&curid=113852

Well this is essentially what we (wikinews) need for google news, there is a problem. The googlebot i believe is prevented via robots.txt from browsing w/index.php... pages.

Would it be possible to make showcurid=true use urls like
http://en.wikinews.org/wiki/CanadaVOTES:_Libertarian_Kevin_Stricker_running_in_Saskatoon%E2%80%94Rosetown%E2%80%94Biggar?curid=113852
instead?

Thanks, Bawolff

p.s. Bastique told me to assign this to Aaron. I've never actually assigned a bug to anybody when entering it, so i hope i did that right. sorry, if i messed that up and it causes any confusion.
Comment 1 Matt Johnston 2008-09-27 09:50:33 UTC
Feature added in r41301, needs to be enabled by a shell once scapped.
Comment 2 Matt Johnston 2008-09-28 23:02:27 UTC
According to Special:Version this should be active, so just waiting on a shell to add the config setting.
Comment 3 Brion Vibber 2008-09-29 22:54:52 UTC
That code looks pretty ugly to me. It's not clearly self-documenting (in getLocalUrl()'s code) and the option is wayyyyyy too specific to seem reasonable.

I recommend backing this change out. A more suitable "temporary hack" would be to just change DynamicPageList to slap that specific option on after the regular URL.
Comment 4 Brion Vibber 2008-09-29 23:03:55 UTC
Reverted r41301 and r41332 in r41402.
Comment 5 Matt Johnston 2008-09-30 02:03:19 UTC
Should be re-added in r41410 and r41411.
Comment 6 Brion Vibber 2008-10-01 21:36:18 UTC
I ended up reverting that in r41507 due to some interwiki breakage.
Comment 7 Aaron Schulz 2008-10-05 00:46:41 UTC
Done in r41573, r41411

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links