Last modified: 2008-11-03 00:04:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17737, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 15737 - Handling of unknown parameters while expanding using PPCustomFrame's
Handling of unknown parameters while expanding using PPCustomFrame's
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Templates (Other open bugs)
1.14.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-09-26 23:13 UTC by Juliano F. Ravasi
Modified: 2008-11-03 00:04 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Proposed patch. (787 bytes, patch)
2008-09-26 23:13 UTC, Juliano F. Ravasi 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Juliano F. Ravasi 2008-09-26 23:13:47 UTC 
Created attachment 5366 [details]
Proposed patch.

In PPCustomFrame_DOM and PPCustomFrame_Hash, no checking is performed in getArgument() when arguments not contained in frames are requested, causing PHP undefined variable error messages. This happens while expanding templates using a custom frame.

A simple check is needed using isset(), just like those found in PPFrame_* and PPTemplateFrame_*.

Patch to fix this problem is attached.
Comment 1 Siebrand Mazeland 2008-11-03 00:04:56 UTC 
Applied in r43105.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links