Last modified: 2010-05-15 16:03:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17706, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15706 - action=query&list=allpages&apprtype&apprlevel= - Ungracefully failing
action=query&list=allpages&apprtype&apprlevel= - Ungracefully failing
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.13.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-24 11:37 UTC by Sam Reed (reedy)
Modified: 2010-05-15 16:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2008-09-24 11:37:19 UTC
http://en.wikipedia.org/w/api.php?action=query&list=allpages&apprtype&apprlevel=

<?xml version="1.0"?>
<api>
  <error code="internal_api_error_MWException" info="Exception Caught: Database::makeList: empty input">

#0 /usr/local/apache/common-local/php-1.5/includes/db/Database.php(1024): Database->makeList(Array, 1)
#1 /usr/local/apache/common-local/php-1.5/includes/db/Database.php(981): Database->selectSQLText(Array, Array, Array, 'ApiQueryAllpage...', Array, Array)
#2 /usr/local/apache/common-local/php-1.5/includes/api/ApiQueryBase.php(214): Database->select(Array, Array, Array, 'ApiQueryAllpage...', Array, Array)
#3 /usr/local/apache/common-local/php-1.5/includes/api/ApiQueryAllpages.php(125): ApiQueryBase->select('ApiQueryAllpage...')
#4 /usr/local/apache/common-local/php-1.5/includes/api/ApiQueryAllpages.php(43): ApiQueryAllpages->run()
#5 /usr/local/apache/common-local/php-1.5/includes/api/ApiQuery.php(211): ApiQueryAllpages->execute()
#6 /usr/local/apache/common-local/php-1.5/includes/api/ApiMain.php(422): ApiQuery->execute()
#7 /usr/local/apache/common-local/php-1.5/includes/api/ApiMain.php(258): ApiMain->executeAction()
#8 /usr/local/apache/common-local/php-1.5/includes/api/ApiMain.php(242): ApiMain->executeActionWithErrorHandling()
#9 /usr/local/apache/common-local/php-1.5/api.php(77): ApiMain->execute()
#10 /usr/local/apache/common-local/live-1.5/api.php(3): require('/usr/local/apac...')
#11 {main}

</error>
</api>


Shouldnt it really fail more gracefully? (obv, the query string is wrong)


Cheers


Sam
Comment 1 Roan Kattouw 2008-09-24 19:36:26 UTC
(In reply to comment #0)
> http://en.wikipedia.org/w/api.php?action=query&list=allpages&apprtype&apprlevel=
> 
> Shouldnt it really fail more gracefully? (obv, the query string is wrong)
> 
It shouldn't accept empty values for one of these parameters. I'll look into this.
Comment 2 Roan Kattouw 2008-09-25 14:55:08 UTC
Fixed in r41255. Empty values for either of these parameters are now silently ignored (i.e. treated as if the parameter were not set).
Comment 3 Sam Reed (reedy) 2008-09-25 15:19:22 UTC
Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links