Last modified: 2008-09-23 18:21:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17672, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 15672 - Diff after rollback in the majority of cases not shown
Diff after rollback in the majority of cases not shown
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-09-21 13:18 UTC by Raimond Spekking
Modified: 2008-09-23 18:21 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Raimond Spekking 2008-09-21 13:18:33 UTC 
Normally a diff of a rollbacked edit is shown on the rollback result page.

But on Wikimedia projects the diff is in the majority of cases not shown. Only sometimes :-/

The HTML source contains an empty table instead:


		<table class='diff'>
		<col class='diff-marker' />
		<col class='diff-content' />
		<col class='diff-marker' />
		<col class='diff-content' />
		<tr valign='top'>

		<td colspan='2' class='diff-otitle'></td>
		<td colspan='2' class='diff-ntitle'></td>
		</tr>
		<!-- diff generator: wikidiff2 srv110 2008-09-20 22:01:18 -->
and same
		<!-- diff generator: wikidiff2 srv173 2008-09-21 11:56:56 -->


A diff was shown from srv155:

<!-- diff generator: wikidiff2 srv155 2008-09-19 19:14:56 -->
<!-- diff cache key dewiki:diff:version:1.11a:oldid:48233907:newid:50914488 -->

I am unsure if it is an issue with MediaWiki code or settings of the servers.
Comment 1 Raimond Spekking 2008-09-23 16:36:34 UTC 
Codeispoetry spotted another server who gave a diff after rollback:

<!-- diff generator: wikidiff2 srv135 2008-09-23 15:49:52 -->
Comment 2 Aaron Schulz 2008-09-23 18:06:59 UTC 
getNextRevisionID() uses a slave (occasionally the master) to find the 'next' revision for the diff
Comment 3 Aaron Schulz 2008-09-23 18:21:14 UTC 
(In reply to comment #2)
> getNextRevisionID() uses a slave (occasionally the master) to find the 'next'
> revision for the diff
> 

Should be fixed in r41198
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links