Last modified: 2009-11-28 04:43:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17629, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 15629 - Form to delete images should have an id, too


Summary:	Form to delete images should have an id, too

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	File management (Other open bugs)
Version:	1.14.x
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Chad H.

URL:
Whiteboard:
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-09-17 15:13 UTC by Platonides
Modified:	2009-11-28 04:43 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add id to form on image deletion (629 bytes, patch) 2008-09-17 15:13 UTC, Platonides	Details
Add an attachment (proposed patch, testcase, etc.)

Description Platonides 2008-09-17 15:13:02 UTC

Patch to add 'deleteconfirm' id to FileDeleteForm, the same name as in Article::confirmDelete. Might make sense to merge those functions.

Comment 1 Platonides 2008-09-17 15:13:50 UTC

Created attachment 5340 [details]
Add id to form on image deletion

Comment 2 Chad H. 2008-09-18 02:54:39 UTC

Used a different id (added the mw- prefix and -img- to help differentiate from the other page). Done in r40972

Comment 3 Platonides 2008-09-18 11:00:01 UTC

I don't see the need to differenciate them, as they're conceptually equivalent for the user (only contents of the comobox change) but ok. I have added the check for the second case to my scripts.
Thanks

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links