Last modified: 2008-09-21 20:01:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17627, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15627 - Other Expiry field isn't hidden if dropdown chosen but page reloaded
Other Expiry field isn't hidden if dropdown chosen but page reloaded
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Matt Johnston
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-17 10:14 UTC by Matt Johnston
Modified: 2008-09-21 20:01 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (737 bytes, patch)
2008-09-17 10:14 UTC, Matt Johnston
Details

Description Matt Johnston 2008-09-17 10:14:45 UTC
Created attachment 5339 [details]
Proposed patch

If you select an expiry from the dropdown, the "other expiry" box is normally hidden, however when the page is refreshed (e.g. if the user hits block but there is an error of some sort), this doesn't happen. This patch simply checks the status on page load (done in JavaScript so as not to hide the box for non-JS clients, where they wouldn't be able to get it back again)
Comment 1 Matt Johnston 2008-09-21 20:01:24 UTC
Fixed in r41128

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links