Last modified: 2010-05-15 15:54:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17611, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15611 - Special:BlockIP no longer supports wpBlockReasonList
Special:BlockIP no longer supports wpBlockReasonList
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.12.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-15 15:53 UTC by Renate
Modified: 2010-05-15 15:54 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Renate 2008-09-15 15:53:01 UTC
As of Version 1.12 the parameter wpBlockReasonList does not seem to be actually supported.
This is a useful feature for emergency bot shutoffs where a main reason is preferred to other.

Version 1.11 iterates through the list of reasons and checks against the supplied wpBlockReasonList.

Version 1.12 just uses Xml::listDropDown which doesn't seem to do any selecting at all.
Comment 1 Aaron Schulz 2008-09-22 13:27:52 UTC
Works in 1.13/1.14a, I'll check 1.12
Comment 2 Aaron Schulz 2008-09-22 13:28:48 UTC
OK, works for me in 1.12
Comment 3 Renate 2008-09-22 20:29:44 UTC
Ok, here's the fix, I don't know enough about PHP or SVN enough to do it globally, but it worked fine on mine.

Change SpecialBlockip.php (line 109-111 in version 1.13) from:

		$reasonDropDown = Xml::listDropDown( 'wpBlockReasonList',
			wfMsgForContent( 'ipbreason-dropdown' ),
			wfMsgForContent( 'ipbreasonotherlist' ), '', 'wpBlockDropDown', 4 );

To:

		$reasonDropDown = Xml::listDropDown( 'wpBlockReasonList',
			wfMsgForContent( 'ipbreason-dropdown' ),
			wfMsgForContent( 'ipbreasonotherlist' ), $this->BlockReasonList, 'wpBlockDropDown', 4 );

The select was never specified in the function call.
Comment 4 Aaron Schulz 2008-09-22 20:37:21 UTC
OK, I see, the problem is just the pre-filling from the url
Comment 5 Aaron Schulz 2008-09-22 20:39:01 UTC
Fixed in r41165

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links