Last modified: 2011-11-20 21:18:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17591, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15591 - Wikibits patch #10 - handling multiple colspans in sortable table headers
Wikibits patch #10 - handling multiple colspans in sortable table headers
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-13 15:48 UTC by bluehairedlawyer
Modified: 2011-11-20 21:18 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
unified diff file (1.26 KB, patch)
2008-09-13 15:48 UTC, bluehairedlawyer
Details

Description bluehairedlawyer 2008-09-13 15:48:18 UTC
Created attachment 5330 [details]
unified diff file

This patch allows users to use use headers which span more than one column in sortable tables.

Currently MediaWiki used .cellIndex to identify the column number that doesn't take account to cells which span more than one column.

In any colspan'ed block of columns, the rows would be sorted by the leftmost column with the rest behaving as unsortable columns.

For an example where this patch would be useful, see http://en.wikipedia.org/wiki/List_of_countries_by_GDP_(nominal)_per_capita my intent would be to have four headers (Country, IMF, World Bank, Cia) over seven columns (Country, IMF rank, IMF figure, World Bank rank, etc...). Rather than the current more confusing layout.
Comment 1 bluehairedlawyer 2008-09-18 23:04:39 UTC
To perhaps better explain this patch in the hope of getting some attention. This patch would allow me to do this on the GDP article table, and similar tables...

+-------------+----------------+----------------+----------------+
| Country     |     IMF        |   World Bank   |     C.I.A.     |
+-------------+------+---------+------+---------+------+---------+
| France      | 1    | 35,000  | 2    | 30,000  | 1    | 33,000  |
| Ireland     | 5    | 20,000  | 3    | 17,000  | 3    | 21,000  |
| Bangalore   | 256  | 5,000   | 100  | 6,000   | 130  | 80,000  |
| ...         |      |         |      |         |      |         |

(I'm not sure if this will display correctly.)
Comment 2 Sumana Harihareswara 2011-11-09 19:21:05 UTC
Adding the "need-review" keyword for patches that need review by developers.  bluehairedlawyer, thank you for your patch, and sorry it's taken so long for a response on this!
Comment 3 Sumana Harihareswara 2011-11-20 21:06:45 UTC
Hey Sam, am I right in inferring that you marked this patch as obsolete because it does not currently apply cleanly to trunk?

bluehairedlawyer, if you're interested in revising your patch to work with MediaWiki's current codebase, please visit us in #mediawiki on IRC https://www.mediawiki.org/wiki/MediaWiki_on_IRC and talk about it.  Thanks.
Comment 4 Sam Reed (reedy) 2011-11-20 21:18:33 UTC
It won't apply as the table sorter code isn't in wikibits now

As well as being pretty obsolete. The code has been rebuilt on jquery, so is completely deprecated

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links