Last modified: 2008-11-03 00:33:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17544, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15544 - Non-index entry points cause the "Wiki not set up" message to have corrupt URLs
Non-index entry points cause the "Wiki not set up" message to have corrupt URLs
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Matt Johnston
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-10 03:34 UTC by Matt Johnston
Modified: 2008-11-03 00:33 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (1.64 KB, patch)
2008-09-10 03:34 UTC, Matt Johnston
Details
Proposed patch v2 (2.26 KB, patch)
2008-09-19 23:18 UTC, Matt Johnston
Details

Description Matt Johnston 2008-09-10 03:34:33 UTC
Created attachment 5310 [details]
Proposed patch

When going through a non-index entry page, e.g. api.php, without the wiki set up, the message that is shown has corrupted urls (e.g. for me, http://localhost/mw/api.phpconfig/index.php), on both the link and the image.

It's a reasonably rare occurence, but may happen on public wikis with bots when updating the software, or accidentally moving/deleting your config.

Patch tested to merge fine on r40691 of trunk
Comment 1 Chad H. 2008-09-11 00:07:59 UTC
Patch applied in r40719
Comment 2 Matt Johnston 2008-09-19 23:14:59 UTC
Reopening per discussion with Tim, needs a more elegant solution that will work with more locations.
Comment 3 Matt Johnston 2008-09-19 23:18:30 UTC
Created attachment 5349 [details]
Proposed patch v2

Fixed patch, finds the correct path if in any subdirectory (of those listed) or if in the main directory. Also validates if it has the right place.
Comment 4 Siebrand Mazeland 2008-11-03 00:33:27 UTC
For completeness sake: r40719 was reverted in r41047 by Tim with comment: Reverted r40719, plainly flawed, for instance the hard-coded references to index.php have no place if the point is to make it work for other entry points.

Applied patch 5349 in r43106.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links