Last modified: 2008-09-06 12:19:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17492, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15492 - list=recentchanges&rctype=log does't list log action
list=recentchanges&rctype=log does't list log action
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-05 22:15 UTC by Gurch
Modified: 2008-09-06 12:19 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (4.79 KB, patch)
2008-09-06 12:08 UTC, Roan Kattouw
Details

Description Gurch 2008-09-05 22:15:22 UTC
In the recent changes API, with everything that can possibly appear in 'rcprop' set (user|comment|flags|timestamp|title|ids|sizes|redirect|patrolled), items of type="log" appear as in the following example:

<rc type="log" ns="2" title="User:75.67.179.152" rcid="242233392" pageid="0" revid="0" old_revid="0" user="LessHeard vanU" oldlen="0" newlen="0" timestamp="2008-09-05T22:08:27Z" comment="[[WP:Disruptive editing|Disruptive editing]]: return to vandalism that incurred previous blocks" patrolled="" />

There is no field for the type of action! The only way I can tell that this is a block is from the edit summary; if there was no summary supplied, I wouldn't know whether it was a block, deletion, protection or something else, and the API is meant for machines, which are not clever enough to infer the meaning of an edit summary.
Comment 1 Roan Kattouw 2008-09-06 11:41:23 UTC
Changing summary: this isn't broken, but a feature request.

I'll write up a patch that implements this. Of course, if you're only interested in log events, you could simply use list=logevents which *does* list the action.
Comment 2 Gurch 2008-09-06 12:07:11 UTC
It is broken in the sense that it worked in MediaWiki 1.12, where the 'title' parameter was given as "Special:Log/[action]" for log entries. I assume a rewrite at some point changed that. It's also broken in the sense that it's not usable for any useful purpose. :)

I'm aware of list=logevents, but if I need all recent changes *and* log actions, it's much quicker and easier if I only have to make one query instead of two. If there was no "rctype=log" action I wouldn't object, but it seems silly to have one but not be able to use it. :)
Comment 3 Roan Kattouw 2008-09-06 12:08:26 UTC
Created attachment 5296 [details]
Patch

The attached patch adds rcprop=loginfo, which adds the logid, logtype and logaction fields, along with the log parameters, to the output.
Comment 4 Gurch 2008-09-06 12:09:31 UTC
Thanks :)
Comment 5 Roan Kattouw 2008-09-06 12:19:22 UTC
Fixed in r40529

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links