Last modified: 2012-11-03 08:44:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 15451 - "Return to..." should link to the last page you were on in all cases
"Return to..." should link to the last page you were on in all cases
Status: NEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.14.x
All All
: Normal normal with 3 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: testme
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-03 05:29 UTC by Mike.lifeguard
Modified: 2012-11-03 08:44 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mike.lifeguard 2008-09-03 05:29:25 UTC
This used to be the case, IIRC, but is not currently. It may be since tonight's scap. Places where this message appears (after deleting, for example) the link always goes to [[Main Page]] and not the page you were last on, or the page you last performed an action on (deleting).
Comment 1 Daniel Friesen 2008-09-03 09:12:24 UTC
As I remember deletion never links back to the page. It links back to the main page instead because there is no page to link back to, you just deleted it...
Comment 2 Mike.lifeguard 2008-09-03 14:12:12 UTC
Yes, apparently this is not new behaviour. However, it doesn't make sense to me to link back to the main page after deleting something. Perhaps removing this altogether makes the most sense, but at a minimum, it should link to the last page visited as is done after logging in (you get a "return to [[wherever]]" that actually makes sense).
Comment 3 Huji 2008-09-03 18:37:44 UTC
There are other instances, apart from deletion, when a link to Main Page is used; in some cases, a link back to the Special Page where the user came from is more appropriate (I don't have an example ready in my mind but they're easy to find). I once became interested in changing this behavior, but then noticed that the mechanism used to generate the link doesn't support a custom link in its current form. I believe this should be changed.
Comment 4 Aaron Schulz 2008-09-05 03:43:11 UTC
What examples are there?
Comment 5 Huji 2008-09-06 16:19:14 UTC
The only one I can recall now is after marking a page as patrolled; you expect to have a way to go back to "that" page, but (as of the last time I tested it) the link is to Main Page.
Comment 6 Mike.lifeguard 2008-10-06 21:47:31 UTC
(In reply to comment #5)
> The only one I can recall now is after marking a page as patrolled; you expect
> to have a way to go back to "that" page, but (as of the last time I tested it)
> the link is to Main Page.
> 

Actually it links back to [[Special:RecentChanges]] on wikis where all changes are patrolled, and back to [[Special:NewPages]] on wikis where only new pages are patrolled.

The ?title= parameter is specified in the URL, so clearly we know what page we were at - the link should be easily made.
Comment 7 Mike.lifeguard 2008-10-06 21:52:31 UTC
Updating summary... it does sometimes work (ie after you log in, it links to the correct page) and I don't know if it ever does link to [[Main Page]].
Comment 8 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-10-06 21:52:41 UTC
There are a number of instances of this.

0 17:51:11 /var/www/git-trunk/phase3$ git grep -n 'returnToMain([^,]*)' | cat
includes/Article.php:2386:				$wgOut->returnToMain( false );
includes/OutputPage.php:1055:		$this->returnToMain();
includes/OutputPage.php:1099:		$this->returnToMain();
includes/OutputPage.php:1125:		$this->returnToMain();
includes/specials/SpecialConfirmemail.php:138:				$wgOut->returnToMain();
includes/specials/SpecialUserlogin.php:142:			$wgOut->returnToMain( false );
includes/specials/SpecialUserlogin.php:733:			$wgOut->returnToMain( null );
includes/specials/SpecialUserlogin.php:750:		$wgOut->returnToMain( false );
includes/specials/SpecialUserlogin.php:777:		$wgOut->returnToMain( false );
includes/specials/SpecialUserlogout.php:22:	$wgOut->returnToMain();

A parameter should be provided for all of those where possible.  This might require the use of extra returnto= parameters in some links so that it knows where to return to.  Where appropriate, we might want to just redirect instead of printing the link.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links