Last modified: 2009-09-29 17:22:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17233, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15233 - Output on diff page uses the ?title= parameter instead of the correct title
Output on diff page uses the ?title= parameter instead of the correct title
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://test.wikipedia.org/w/index.php...
:
: 14238 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-18 20:49 UTC by Mormegil
Modified: 2009-09-29 17:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
An ugly "fix" showing the problem cause (420 bytes, patch)
2008-08-18 20:49 UTC, Mormegil
Details

Description Mormegil 2008-08-18 20:49:07 UTC
When viewing a diff, you are not required to pass the “title” parameter at all, or you can pass any garbage in it (e.g. http://test.wikipedia.org/w/index.php?title=Nonexisting_page_title&diff=62541). However, the title is not ignored completely – it is used as the real page title by the parser rendering the new version displayed under the diff.

That means that (see the linked URL):
1. The tabs above lead to the page given in ?title= (or to the Main Page, if no title has been given), not to the displayed page. They might be red, if that page does not exist.
2. Any subpage links referenced in the page text are broken: they lead to the respective subpage of the page given in ?title=, not to the subpages of the displayed page.

An ugly “fix” is attached, I am not sure if something like that should be the proper solution; it is more like a pointer to the problem.
Comment 1 Mormegil 2008-08-18 20:49:54 UTC
Created attachment 5193 [details]
An ugly "fix" showing the problem cause
Comment 2 Aaron Schulz 2009-01-06 20:55:16 UTC
Fixed in r45458
Comment 3 Brion Vibber 2009-01-07 04:01:33 UTC
This code is illegible; it's not very clear what it's doing or why. Please redo with clearer code; comment if necessary.

Reverted in r45486
Comment 4 Aaron Schulz 2009-01-07 13:23:24 UTC
...done in r45500
Comment 5 Alexandre Emsenhuber [IAlex] 2009-09-29 17:22:14 UTC
*** Bug 14238 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links