Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17128, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 15128 - Feed::xmlEncode() function should be declared static

Summary:	Feed::xmlEncode() function should be declared static

Status: RESOLVED INVALID Product: MediaWiki Classification: Unclassified Component: General/Unknown (Other open bugs) Version: unspecified Hardware: All All Importance: Normal trivial (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2008-08-12 01:41 UTC by Iaroslav Vassiliev Modified: 2008-08-13 01:53 UTC (History) CC List: 2 users (show) ayg skizzerz See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Iaroslav Vassiliev 2008-08-12 01:41:35 UTC There seems to be a little bug in includes/Feed.php file. Although Feed::xmlEncode($string) function is marked in SVN documentation as static, it isn't really declared as static, and that causes compiler errors when E_STRICT PHP warnings level is enabled. Comment 1 Ryan Schmidt 2008-08-12 01:47:51 UTC fixed in r39198 Comment 2 Brion Vibber 2008-08-12 20:14:22 UTC Reverted in r39240. The function is only called *non*-statically. Comment 3 Iaroslav Vassiliev 2008-08-13 01:38:05 UTC Then an update in documentation is needed. Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-08-13 01:53:23 UTC Done in r39265.