Last modified: 2008-08-09 21:34:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17096, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15096 - Unnecessary purging when sighting templates
Unnecessary purging when sighting templates
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-09 08:58 UTC by Matt
Modified: 2008-08-09 21:34 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matt 2008-08-09 08:58:52 UTC
On enwikinews, I went through a few of our most popular templates, and sighted the latest versions (which predated flaggedrevs being turned on), yet it still added approximately the number of transclusions to the job queue (I'm assuming here it's purging for when it doesnt use the latest version, but the sighted version, of templates to anons). This is unnecessary, as they are already transcluded with the right versions as they predate flaggedrevs, and there are no other sighted versions anyway.

This causes quite a bit of work on the job queue, which isn't a big problem for enwikinews where top template is 13K transclusions, but might be for bigger wikis where you get multi-million transcluded templates.

Maybe a check for whether the edit being sighted is earlier than the first sighting entry in the log, or something similair that will represent when flagedrevs was installed. (or you could check if there are no other revisions of that page that are sighted, which would do the same thing I presume, and be more useful in the long run)
Comment 1 Aaron Schulz 2008-08-09 15:05:15 UTC
Whether the template's latest version was made before then doesn't really matter; pages could still use it. Also, checking those dates is pretty hacky.
Comment 2 Matt 2008-08-09 21:32:12 UTC
If it doesnt have any sighted revisions why do you need to purge on both edit and sight?
Comment 3 Aaron Schulz 2008-08-09 21:34:07 UTC
The templates used on pages depend on the stable versions of templates, so as they change, so should pages that use them.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links