Last modified: 2008-08-05 16:03:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T17010, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 15010 - Patch for UsernameBlacklist to support multiple blacklist sources
Patch for UsernameBlacklist to support multiple blacklist sources
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsernameBlacklist (Other open bugs)
unspecified
All All
: Normal enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-02 04:11 UTC by Fran Rogers
Modified: 2008-08-05 16:03 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for UsernameBlacklist to support multiple blacklist sources (92.13 KB, patch)
2008-08-02 04:11 UTC, Fran Rogers
Details

Description Fran Rogers 2008-08-02 04:11:22 UTC
Created attachment 5114 [details]
Patch for UsernameBlacklist to support multiple blacklist sources

Recent problems with vandals jumping across wikis have highlighted the need for a global username blacklist on Wikimedia projects. The Spam and Title blacklists already have support for multiple sources, and accordingly have global blacklists on Meta; however, the UsernameBlacklist is older and no longer maintained, and only sources from a local MediaWiki: message.

I've attached a patch against the most recent SVN version of UsernameBlacklist that adds support for multiple blacklist sources patterned on that of TitleBlacklist, so that a global username blacklist can be created on Meta alongside the spam and title blacklists. It also updates the syntax to keep it in line with that of TitleBlacklist so the two can easily be updated in tandem. I've also incorporated the fix for bug 14941 that was causing the UsernameBlacklist to mysteriously crash en.wiki.
Comment 1 Brion Vibber 2008-08-04 01:39:10 UTC
Patch is overly large, seems to change lots of unrelated things (formatting etc), and appears to be missing almost all of the actual code. It looks like it adds new files but doesn't include them.
Comment 2 Fran Rogers 2008-08-05 16:03:17 UTC
Actually, thinking things over, I think it makes more sense to integrate username blacklist capabilities into TitleBlacklist, then to retrofit TitleBlacklist's improvements on UsernameBlacklist - on most wikis the two blacklists are going to be closely intertwined anyway. :) I've added said functionality to TitleBlacklist in r38636.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links