Last modified: 2009-03-28 08:22:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16980, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14980 - Merge messages 'sharedupload' and 'shareduploadwiki'/'shareduploadwiki-desc'
Merge messages 'sharedupload' and 'shareduploadwiki'/'shareduploadwiki-desc'
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Chad H.
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-30 10:20 UTC by Jon Harald Søby
Modified: 2009-03-28 08:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon Harald Søby 2008-07-30 10:20:19 UTC
Currently the messages 'sharedupload' and 'shareduploadwiki' or 'shareduploadwiki-desc' are called independently. That is, 'sharedupload' is used every time there is a shared upload, while 'shareduploadwiki-desc' is used when the description page could be imported, and 'shareduploadwiki' is used when it’s not. However, I would like for 'shareduploadwiki' and 'shareduploadwiki-desc' to be called within 'sharedupload', as parameter $1.

This would make it easier and less fragmented to integrate the two messages, the way it is done on [1] and [2]. Also it would be possible to integrate them while still keeping one layout like it's done on those two pages.

All that will need to change in LanguagesEn.php is to append '$1' in 'sharedupload'; some more changes will be needed in ImagePage.php though, but I assume it will be simple for someone who knows more PHP than I do.

[1] http://en.wikipedia.org/wiki/MediaWiki:Sharedupload
[2] http://de.wikipedia.org/wiki/MediaWiki:Sharedupload
Comment 1 Siebrand Mazeland 2008-08-11 22:09:04 UTC
Assigned to demon.
Comment 2 Chad H. 2009-02-17 23:18:54 UTC
Done in r47394
Comment 3 Niklas Laxström 2009-03-28 08:22:16 UTC
Fixed in a another way in r48951.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links