Last modified: 2009-02-01 19:03:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16938, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14938 - Section editing: removing sections leaves excess whitespace
Section editing: removing sections leaves excess whitespace
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.14.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-26 22:52 UTC by Mike.lifeguard
Modified: 2009-02-01 19:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Don't add newlines when the section is blank (664 bytes, patch)
2009-02-01 16:19 UTC, bluehairedlawyer
Details

Description Mike.lifeguard 2008-07-26 22:52:59 UTC
When removing an entire section using section editing, excess whitespace is left behind. This is an annoyance especially when archiving section-by-section, and necessitates an extra edit at the end of an archive run to remove extra blank lines. Upon saving an empty section, a check should be done that extra lines are not being left behind - if so, remove them silently to avoid this issue.
Comment 1 Brion Vibber 2008-08-01 17:09:21 UTC
(Note that the lines don't hurt anything -- there's no actual reason to go back and remove them in a second edit.)
Comment 2 Mike.lifeguard 2008-08-01 17:23:07 UTC
Except that when you remove several sections together, the added newlines end up leaving excess whitespace in the rendered page, which is ugly.
Comment 3 Martin Zeise 2008-09-26 19:15:28 UTC
(In reply to comment #0)
I'd like to support Mike.lifeguards' idea. I also find it annoyiung when a blank line ist left after removing a section.

Comment 4 Mike.lifeguard 2008-09-30 18:45:55 UTC
IIRC, some similar check is done within edit summaries - if the last character is a space, silently drop it. Similarly here - the newlines are useless, so please have them silently stripped upon save.
Comment 5 Mike.lifeguard 2009-01-11 17:46:57 UTC
Bug 16116 related
Comment 6 bluehairedlawyer 2009-02-01 16:19:50 UTC
Created attachment 5766 [details]
Don't add newlines when the section is blank

This is very easily fixed. These are newlines that the program adds in by default. Under this patch we don't add them in when the section is empty.
Comment 7 Siebrand Mazeland 2009-02-01 19:03:41 UTC
Patch applied in r46684. Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links