Last modified: 2008-07-31 15:48:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16870, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14870 - FTBFS with GCC 4.3
FTBFS with GCC 4.3
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
wikidiff2 (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Tim Starling
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-20 17:17 UTC by OverlordQ
Modified: 2008-07-31 15:48 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
add required header. (384 bytes, patch)
2008-07-20 17:17 UTC, OverlordQ
Details

Description OverlordQ 2008-07-20 17:17:20 UTC
Created attachment 5088 [details]
add required header.

Relatively old bug since 4.3 has been out for a while, but in 4.3 header dependencies were fixed, and thus wikidiff2.cpp fails to build.

=====
g++ -O2 `php-config --includes` -shared -fPIC -o php_wikidiff2.so wikidiff2.cpp wikidiff2_wrap.cpp
wikidiff2.cpp: In function 'void line_explode(const char*, std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)':
wikidiff2.cpp:401: error: 'strchr' was not declared in this scope
wikidiff2.cpp:403: error: 'strlen' was not declared in this scope
wikidiff2.cpp: In function 'const char* wikidiff2_do_diff(const char*, const char*, int)':
wikidiff2.cpp:423: error: 'strlen' was not declared in this scope
wikidiff2.cpp:429: error: 'strdup' was not declared in this scope
wikidiff2.cpp:431: error: 'strdup' was not declared in this scope
wikidiff2.cpp:433: error: 'strdup' was not declared in this scope
make[1]: *** [php_wikidiff2.so] Error 1
make[1]: Leaving directory `/root/wikidiff2'
=====

just needs a little love from string.h
Comment 1 Brion Vibber 2008-07-31 15:48:49 UTC
Applied in r38301

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links