Last modified: 2010-05-15 15:54:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16778, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14778 - PageHistory don't use limit
PageHistory don't use limit
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.12.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-10 07:54 UTC by Cédric Chantepie
Modified: 2010-05-15 15:54 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
PageHistory patch (284 bytes, patch)
2008-07-10 07:54 UTC, Cédric Chantepie
Details

Description Cédric Chantepie 2008-07-10 07:54:23 UTC
Created attachment 5063 [details]
PageHistory patch

PageHistory don't use limit request parameter.
Comment 1 Chad H. 2008-07-10 14:53:32 UTC
Done in r37508
Comment 2 FunPika 2008-07-10 21:38:03 UTC
Reverted in r37536 by Brion
Comment 3 Cédric Chantepie 2008-07-11 07:22:49 UTC
(In reply to comment #2)
> Reverted in r37536 by Brion 

Why ?
Comment 4 Niklas Laxström 2008-07-11 07:26:07 UTC
Clicking the link would have told you:
Revert r37508 for now ((bug 14778) 'limit' parameter now applies to history feeds as well as history pages)
The $limit parameter isn't validated properly as a limit, and is passed to the database producing an SQL error if negative.
Comment 5 Chad H. 2008-07-15 16:01:24 UTC
Reimplemented in r37699, no longer allows negatives.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links