Last modified: 2008-07-07 09:51:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14745 - Image move/rename doesn't work on sites that transform thumbnails via 404
Image move/rename doesn't work on sites that transform thumbnails via 404
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2008-07-06 22:18 UTC by Brion Vibber
Modified: 2008-07-07 09:51 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Brion Vibber 2008-07-06 22:18:59 UTC
The image records in the DB get changed, but the file on disk isn't moved, making the exercise rather... broken. Currently enabled for sysops only on during testing.

Some log extracts...

A local test, working:
2008-07-06 22:01:33 shortwiki: Got request to move Rana_skeleton.png to Rana skeleton moved.png
2008-07-06 22:01:33 shortwiki: Cannot transform via 404, so move thumbnails
2008-07-06 22:01:33 shortwiki: Generated move triplet for Rana_skeleton.png: mwrepo://local/public/a%2Fae%2FRana_skeleton.png :: public :: 4/40/Rana_skeleton_moved.png
2008-07-06 22:01:33 shortwiki: Renamed Rana_skeleton.png in database: 1 successes, 0 failures
2008-07-06 22:01:33 shortwiki: Moved files for Rana_skeleton.png: 1 successes, 0 failures
2008-07-06 22:01:33 shortwiki: Finished moving Rana_skeleton.png
A live test, failed (apparent success in db but actual file not moved):
2008-07-06 22:09:18 testwiki: Got request to move Image_move_test.png to Image move test target.png
2008-07-06 22:09:18 testwiki: No moving thumbnails, ok to transform via 404
2008-07-06 22:09:18 testwiki: Renamed Image_move_test.png in database: 1 successes, 0 failures
2008-07-06 22:09:18 testwiki: Moved files for Image_move_test.png: 0 successes, 0 failures
2008-07-06 22:09:18 testwiki: Finished moving Image_move_test.png

It appears that it's simply not bothering to schedule any renames for the filesystem, so nothing gets renamed.
Comment 1 Bryan Tong Minh 2008-07-07 09:51:31 UTC
Fixed in r37239. It was merging a null with an array.

Note You need to log in before you can comment on or make changes to this bug.