Last modified: 2012-08-14 11:37:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14698 - Special:CreateAccount does not respect "Prevent account creation" from Special:BlockIP
Special:CreateAccount does not respect "Prevent account creation" from Specia...
Status: RESOLVED DUPLICATE of bug 13611
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.13.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-01 18:55 UTC by Raimond Spekking
Modified: 2012-08-14 11:37 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
getUserPermissionsErrors Patch (433 bytes, patch)
2008-07-07 07:00 UTC, Nigel Jones
Details

Description Raimond Spekking 2008-07-01 18:55:08 UTC
Test case [[Special:BlockIP]]:

IP Address or username: any IP address
Expiry:                 whatever you like
Reason:                 ...

Other/additional reason: 	
 [X] 	 Block anonymous users only
 [ ] 	 Prevent account creation
 [ ]	 Automatically block the last IP address used by this user,...

Note that "Prevent account creation" is not marked!

When a user tries to register an account via [[Special:CreateAccount]] he get the standard block message even if "Prevent account creation" was not marked.
Comment 1 Chad H. 2008-07-02 14:44:13 UTC
Fixed in r36916
Comment 2 Brion Vibber 2008-07-03 20:11:08 UTC
This doesn't appear to be working the right way; it's finding that permission is not allowed, but then trying to ignore particular reasons why it might not be allowed.
Correct fix should be to ensure that the correct result is actually obtained from the permission check in the first place!
Note that the error key may have 'autoblocktext' for autoblocks, which would not match this check as written.

Reverted for now in r37002
Comment 3 Nigel Jones 2008-07-07 07:00:37 UTC
Created attachment 5056 [details]
getUserPermissionsErrors Patch

Basically according to be debug logs, we are basically checking the block logs twice...

Once to work out if they have a block preventing account creation (correct) which is line 727 of SpecialUserlogin.php
Then again, when we check that the LocalSettings.php file doesn't have $wgGroupPermissions[*]['createaccount'] = false via getUserPermissionsErrors, which is line 730 of SpecialUserlogin.php, normally this makes sense, but it's blind to the prevent account creation flag so it's no good for us.

Simple solution is don't run block check in getUserPermissionsErrors if the action is createaccount.
Comment 4 Siebrand Mazeland 2008-08-13 12:21:01 UTC
Keywords: patch, need-review
Assigned: brion, as he reverted the previous commit that fixed this issue.
Comment 5 Aaron Schulz 2008-09-22 13:23:31 UTC

*** This bug has been marked as a duplicate of bug 13611 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links