Last modified: 2013-08-26 22:19:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16652, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14652 - Allow ZIP CAPAB on irc.wikimedia.org
Allow ZIP CAPAB on irc.wikimedia.org
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
IRC (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review, upstream
Depends on: 42789
Blocks: 16599
  Show dependency treegraph
 
Reported: 2008-06-26 14:52 UTC by Platonides
Modified: 2013-08-26 22:19 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Add ZIP CAPAB for users to ircd-hybrid-6.4.4 (1.35 KB, patch)
2008-12-29 18:56 UTC, Platonides
Details

Description Platonides 2008-06-26 14:52:01 UTC
CAPAB is an irc extension of ircd hybrid which allows to request a extension for a link. If either end don't support a capability (or CAPAB command at all) it is ignored. CAPABility ZIP allows for data compression (the server must be compiled with ZIP_LINKS). 

Many uses of irc.wikimedia.org involve specific software, which are likely to add support for it (as opposed to normal irc clients), and given the amount of messages on that server, compression would make a difference on user bandwidth.

However, use of compression is not allowed for clients.

I'd have filled this bug time ago, but after querying about it, thought the code wasn't available any more. So _please_ put it on svn (either full or as a diff)
Comment 1 Siebrand Mazeland 2008-08-13 17:43:07 UTC
Inspired by bug 14658, by the way.
Comment 2 Siebrand Mazeland 2008-08-13 17:43:51 UTC
Ignore comment 1, please. I thought I was typing on another report.
Comment 3 Platonides 2008-12-29 18:56:48 UTC
Created attachment 5627 [details]
Add ZIP CAPAB for users to ircd-hybrid-6.4.4

Patch against ircd-hybrid-6.4.4 which adds the ZIP CAPAB to users.
Comment 4 Mike.lifeguard 2009-03-23 01:41:29 UTC
We have an 'IRC' component now.
Comment 5 Brion Vibber 2009-05-28 19:08:37 UTC
Here Fred, have a fun one. :) Not a high priority but might be nice to get off the list if it looks feasible.
Comment 6 Fred Vassard 2009-06-16 20:12:31 UTC
ZIP CABAP has been enabled: 

Compiling ircd-ratbox stable

Installing into: /usr/local/ircd-ratbox
Ziplinks ....................... yes
OpenSSL ........................ no
Modules ........................ shared
IPv6 support ................... no
Net I/O implementation ......... epoll
IO Debugging hooks ............. no
Assert debugging ............... no
Small network .................. no
ratbox-services compatibility .. yes


Resolving. 

Comment 7 Platonides 2009-06-22 23:58:17 UTC
The enabled capability is for server<->server communication.
This bug is for clients to be able to receive the events compressed.
Comment 8 p858snake 2011-04-30 00:09:47 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 9 Dereckson 2012-12-06 17:09:44 UTC
I've opened bug 42789 to see if we can get the IRCD source code on a Gerrit repo to apply this patch.
Comment 10 Antoine "hashar" Musso (WMF) 2013-03-16 20:49:25 UTC
This patch is years old, maybe you should consider sending it to upstream http://www.ircd-hybrid.org/ .  That might land on our servers via Ubuntu before we managed to apply the patch ourself :-]
Comment 11 Andre Klapper 2013-07-25 18:15:40 UTC
Platonides: Have you considered writing your patch against code of current trunk in http://svn.ircd-hybrid.org:8000/viewcvs.cgi/ircd-hybrid/trunk/ and upstreaming that patch? See comment 10.

I'd prefer to try that first (especially due to the reviewing expertise of upstream maintainers - I don't expect anybody of Wikimedia ops to know the IRCD code by heart) to maintaining local patches, at least as long as upstream has not rejected a patch *yet*.  :)
Comment 12 Antoine "hashar" Musso (WMF) 2013-08-26 13:41:54 UTC
We use irc-ratbox.  None of the irc server I am connected to seems to offer a ZIP capability.

I don't think we should maintain such a patch locally, it is much better to have it reviewed upstream and merged there for long term maintenance.  That will benefit other users as well.

Given the capability is not that much of an issue for the server, I don't think we need to keep this bug report around.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links