Last modified: 2011-03-09 00:11:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 14645 - Special:SpecialPages should indicate cached and disabled query pages
Special:SpecialPages should indicate cached and disabled query pages
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-25 17:26 UTC by Danny B.
Modified: 2011-03-09 00:11 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Functional patch v1 (3.23 KB, patch)
2011-03-08 21:42 UTC, Jarry1250
Details
Patch v2 (3.23 KB, patch)
2011-03-08 23:01 UTC, Jarry1250
Details
Patch v3 (3.52 KB, patch)
2011-03-08 23:04 UTC, Jarry1250
Details
Patch v4 (3.52 KB, patch)
2011-03-08 23:08 UTC, Jarry1250
Details

Description Danny B. 2008-06-25 17:26:05 UTC
Special:SpecialPages should show if such special page is out of use.

Typically Special:WantedPages is off, thus there should be some notice about that on Special:SpecialPages, say:

* Wanted pages (off)
Comment 1 Jarry1250 2011-03-08 21:42:32 UTC
Created attachment 8266 [details]
Functional patch v1

My first attempt to hack MW, feel free to adjust / reject / laugh at it at will.

In short, it moves over to a semantically valid CSS-only markup, then readds the bolding for restricted pages and adds a new class for cache-only pages. Then it adds italics as the default styling for these.

It could just as easily leave them un-styled by default, but I suppose then the new default notes message might look a little odd.
Comment 2 Ilmari Karonen 2011-03-08 22:26:21 UTC
Patch looks good to me.  Have not tested yet.
Comment 3 Ilmari Karonen 2011-03-08 22:55:41 UTC
OK, tested the patch.  Found a few small issues:

- If a special page is both expensive and restricted, the classes get concatenated with no space in between.  I'd suggest using an array instead and imploding it.

- The specialpages-note message is only shown if the list includes restricted pages.  The condition should be changed to also show it if there are cached pages.

(Also, ideally the message would be split so that we could only show the parts matching pages actually present in the list, but I think it's good enough as it is.)
Comment 4 p858snake 2011-03-08 22:58:05 UTC
-need-review +reviewed per Iimari
Comment 5 Jarry1250 2011-03-08 23:01:03 UTC
Created attachment 8268 [details]
Patch v2

Thanks for the review. Yes, I was going to implement an OR feature for showing the notes, seems reasonable (obviously forgot).
Comment 6 Jarry1250 2011-03-08 23:04:10 UTC
Created attachment 8269 [details]
Patch v3

Oops. Meant to attach this one instead. Sorry all.
Comment 7 Jarry1250 2011-03-08 23:08:47 UTC
Created attachment 8270 [details]
Patch v4

Okay, this is definitely the patch I meant to attach this time. I think. :)
Comment 8 Ilmari Karonen 2011-03-09 00:11:21 UTC
Applied with a few tweaks in r83554.  I decided to move the isExpensive() method up to the SpecialPage class and get rid of the method_exists() kluge -- it's IMO more elegant this way.

Oh, and thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links