Last modified: 2010-05-15 15:28:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1462 - removing of copyright upload affirmation
removing of copyright upload affirmation
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.3.x
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-02-04 07:02 UTC by Nathan Hubbard
Modified: 2010-05-15 15:28 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nathan Hubbard 2005-02-04 07:02:19 UTC
I wrote this quick patch to 1.3.9 after some mods to our Intranet wiki.  It
might be useful to others looking to turn it off as well.  The patch modifies
DefaultSettings.php and SpecialUpload.php.


To use, define in LocalSettings.php:

$wgCheckCopyrightUpload = false;



diff -urN mediawiki-1.3.9/includes/DefaultSettings.php
wiki/includes/DefaultSettings.php
--- mediawiki-1.3.9/includes/DefaultSettings.php        Sun Dec 12 15:36:28 2004
+++ wiki/includes/DefaultSettings.php   Thu Feb  3 22:43:39 2005
@@ -406,6 +406,9 @@
 # copyright information values are not empty.
 $wgCheckCopyrightUpload = true;
 
+# Set this to false if you want to disable copyright checking on uploads
+$wgCopyrightUploadConfirm = true;
+
 
 # Set this to false to avoid forcing the first letter of links
 # to capitals. WARNING: may break links! This makes links
diff -urN mediawiki-1.3.9/includes/SpecialUpload.php wiki/includes/SpecialUpload.php
--- mediawiki-1.3.9/includes/SpecialUpload.php  Sun Dec 12 15:31:33 2004
+++ wiki/includes/SpecialUpload.php     Thu Feb  3 22:41:19 2005
@@ -148,9 +148,11 @@
                }
 
                /** User need to confirm his upload */
-               if( !$this->mUploadAffirm ) {
-                       $this->mainUploadForm( wfMsg( 'noaffirmation' ) );
-                       return;
+               if ( $wgCopyrightUploadConfirm ) {
+                       if( !$this->mUploadAffirm ) {
+                               $this->mainUploadForm( wfMsg( 'noaffirmation' ) );
+                               return;
+                       }
                }
 
                # Chop off any directories in the given filename
@@ -501,11 +503,15 @@
                $titleObj = Title::makeTitle( NS_SPECIAL, 'Upload' );
                $action = $titleObj->escapeLocalURL();
 
-               $source = "
+               $source = "";
+                if (  $wgCopyrightUploadConfirm ) { 
+                       $source = "
        <td align='right'>
        <input tabindex='3' type='checkbox' name=\"wpUploadAffirm\" value=\"1\"
id=\"wpUploadAffirm\" />
        </td><td align='left'><label for=\"wpUploadAffirm\">{$ca}</label></td>
        " ;
+               }
+
                if ( $wgUseCopyrightUpload )
                  {
                        $source = "
Comment 1 T. Gries 2005-02-04 19:09:37 UTC
(In reply to comment #0)
> I wrote this quick patch to 1.3.9 after some mods to our Intranet wiki.  It
> might be useful to others looking to turn it off as well.  The patch modifies
> DefaultSettings.php and SpecialUpload.php.
> 

Yyou have my SUPPORT !

Perhaps (JeLuF ? Brion ? Hashar ?) can someone put this into CVS HEAD 1.5 and
change the version flag on the bugzilla ?
Comment 2 Niklas Laxström 2005-07-10 10:32:26 UTC
Err? Don't we have this already?

Snip from DefaultSettings.php

/* Set this to true if you want the annoying copyright confirmation
 *  checkbox at Special:Upload */
$wgCopyrightAffirmation = false;
Comment 3 Zigger 2005-07-10 12:05:46 UTC
(In reply to comment #2)
> Err? Don't we have this already?

Yes.  Fixed between 1.5alpha2 and 1.5beta1 by 'avar' 22-June-2005.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links