Wikimedia Bugzilla is closed!

*** Bug 14704 has been marked as a duplicate of this bug. ***

Looks good. But $wgFlagRestrictions seems confused there. Note that it is for rights, not groups.

'review' is the basic right to review anything at all. So having it more restrictive than 'editor' doesn't make much sense. 'review' should be the "lower" right, and the "higher" one should be called something else, probably 'validate' (since there is automatically a group ("reviewer" with 'validate').

Lastly, that "cascade" variable was removed; it is always on, so not need to have it in the config.

(In reply to comment #2)
> Looks good. But $wgFlagRestrictions seems confused there. Note that it is for
> rights, not groups.
> 
> 'review' is the basic right to review anything at all. So having it more
> restrictive than 'editor' doesn't make much sense. 'review' should be the
> "lower" right, and the "higher" one should be called something else, probably
> 'validate' (since there is automatically a group ("reviewer" with 'validate').

So when the conditions in $wgFlaggedRevsAutopromote are met, a person
is promoted to editor which gives them the 'review' right? English Wikibooks basically
wants anyone who meets the conditions in $wgFlaggedRevsAutopromote to be able to
rate a page based on its composition, accuracy and coverage with a rating level
between 1 and 3, while restricting the right to use a level 4 rating to sysops.

So if I understand correctly $wgFlagRestrictions should be set to:

$wgFlagRestrictions = array(
  'composition' => array( 'review' => 3 ),
  'accuracy' => array( 'review' => 3 ),
  'coverage' => array( 'review' => 3 ),
);

and anyone with the validate right will be able to set each flag to 4.

The configuration section of FlaggedRevs.php in svn suggests that
sysops and bureaucrats can't review and validate pages without belonging
to the editor and reviewer groups. If this is the case than sysops and
bureaucrats need to have all the editor and reviewer rights set for them
as well, so that sysops and bureaucrats have the rights to 'review' and
'validate' pages.

By default, sysops can grant/revoke 'editor' group rights, and crats can grant/revoke 'reviewer' group rights.

(In reply to comment #4)
> By default, sysops can grant/revoke 'editor' group rights, and crats can
> grant/revoke 'reviewer' group rights.

I'm not talking about the right to grant or revoke these two groups. Rather
that since the proposed settings for $wgFlaggedRestrictions was incorrect
that what we want in order to achieve the results we were after would be
equivalent to sysops and bureaucrats automatically belonging to both groups.

For instance by doing:

$wgGroupPermissions['sysop']['review']          = true;
$wgGroupPermissions['sysop']['autoreview']      = true;
$wgGroupPermissions['sysop']['autoconfirmed']   = true;
$wgGroupPermissions['sysop']['patrolmarks']     = true;
$wgGroupPermissions['sysop']['autopatrolother'] = true;
$wgGroupPermissions['sysop']['unreviewedpages'] = true;
$wgGroupPermissions['sysop']['validate']        = true;

$wgGroupPermissions['bureaucrat']['review']          = true;
$wgGroupPermissions['bureaucrat']['autoreview']      = true;
$wgGroupPermissions['bureaucrat']['autoconfirmed']   = true;
$wgGroupPermissions['bureaucrat']['patrolmarks']     = true;
$wgGroupPermissions['bureaucrat']['autopatrolother'] = true;
$wgGroupPermissions['bureaucrat']['unreviewedpages'] = true;
$wgGroupPermissions['bureaucrat']['validate']        = true;

If you want to skip the step of "self-promotion", that config is fine, except for the fact that Sysop has 'validate' for some reason.

(In reply to comment #6)
> If you want to skip the step of "self-promotion", that config is fine, except
> for the fact that Sysop has 'validate' for some reason.

That's because the intention was for sysops to be able to validate pages as
featured by changing the 3 flag levels to 4, not just bureaucrats.

(In reply to comment #7)
> (In reply to comment #6)
> > If you want to skip the step of "self-promotion", that config is fine, except
> > for the fact that Sysop has 'validate' for some reason.
> 
> That's because the intention was for sysops to be able to validate pages as
> featured by changing the 3 flag levels to 4, not just bureaucrats.
> 

I see. Are there any bureaucrats that are not sysops btw?

No, there aren't.

Do you need more info for this bug, or is it clear now?

Hmm, lots of differences from defaults (which were tweaked for WMF recently). At any rate, looks like we need:


$wgFlaggedRevsNamespaces = array(NS_MAIN, NS_IMAGE, NS_TEMPLATE, 102, 110); // Cookbook, WikiJunior

$wgFlaggedRevTags = array(
  'composition' => 3,
  'accuracy' => 2,
  'coverage' => 2
);
$wgFlagRestrictions = array(
  'composition' => array( 'review' => 3 ),
  'accuracy'    => array( 'review' => 3 ),
  'coverage'    => array( 'review' => 3 ),
);
$wgSimpleFlaggedRevsUI = false;
$wgFlaggedRevTabs = false;
$wgFlaggedRevComments = true;

$wgFlaggedRevsAutopromote = array(
  'days' => 30, # days since registration
  'edits' => 100, # total edit count
  'excludeDeleted' => true, # exclude deleted edits from 'edits' count above?
  'spacing' => 3, # spacing of edit intervals
  'benchmarks' => 15, # how many edit intervals are needed?
  'recentContentEdits' => 10, # $wgContentNamespaces edits in recent changes
  'totalContentEdits' => 50,  # $wgContentNamespaces edits
  'uniqueContentPages' => 10, # $wgContentNamespaces unique pages edited
  'editComments' => 50, # how many edit comments used?
  'email' => true, # user must be emailconfirmed?
  'userpage' => true, # user must have a userpage?
  'userpageBytes' => 1 # if userpage is needed, what is the min size?
  'uniqueIPAddress' => true, # If $wgPutIPinRC is true, users sharing IPs won't be promoted
  'neverBlocked' => true, # Can users that were blocked be promoted?
  'noSorbsMatches' => false, # If $wgSorbsUrl is set, do not promote users that match
);

$wgGroupPermissions['sysop']['review']          = true;
$wgGroupPermissions['sysop']['autoreview']      = true;
$wgGroupPermissions['sysop']['autoconfirmed']   = true;
$wgGroupPermissions['sysop']['patrolmarks']     = true;
$wgGroupPermissions['sysop']['autopatrolother'] = true;
$wgGroupPermissions['sysop']['unreviewedpages'] = true;
$wgGroupPermissions['sysop']['validate']        = true;

Adding my name to this.  Is there any more holdup on this now that we've got the things in place?

Cary

FlaggedRevs is now enabled on this project.. closing bug.

DB query indicates that some pages are using a custom "precedence/selection" setting for the stable version. This feature should be removed. What is it used for currently?

(In reply to comment #14)
> DB query indicates that some pages are using a custom "precedence/selection"
> setting for the stable version. This feature should be removed. What is it used
> for currently?

This is the "Stable version selection precedence" option at special:stabilization for pages.